Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: content/renderer/media/video_source_handler.cc

Issue 14969013: Replace ASSERT with DCHECK per chromium style guide. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/video_destination_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/video_source_handler.cc
===================================================================
--- content/renderer/media/video_source_handler.cc (revision 199242)
+++ content/renderer/media/video_source_handler.cc (working copy)
@@ -62,7 +62,7 @@
VideoSourceHandler::~VideoSourceHandler() {
// All the opened readers should have been closed by now.
- ASSERT(reader_to_receiver_.empty());
+ DCHECK(reader_to_receiver_.empty());
}
bool VideoSourceHandler::Open(const std::string& url,
@@ -88,7 +88,11 @@
}
PpFrameReceiver* receiver =
static_cast<PpFrameReceiver*>(GetReceiver(reader));
- ASSERT(receiver != NULL);
+ if (!receiver) {
+ LOG(ERROR) << "VideoSourceHandler::Close - Failed to find receiver that "
+ << "is associated with the given reader.";
+ return false;
+ }
receiver->SetReader(NULL);
source->RemoveSink(receiver);
reader_to_receiver_.erase(reader);
« no previous file with comments | « content/renderer/media/video_destination_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698