Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: components/web_modal/web_contents_modal_dialog_manager_unittest.cc

Issue 14969012: components: Create web_modal component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix-gtk-build Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/web_modal/web_contents_modal_dialog_manager_unittest.cc
diff --git a/chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc b/components/web_modal/web_contents_modal_dialog_manager_unittest.cc
similarity index 63%
rename from chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc
rename to components/web_modal/web_contents_modal_dialog_manager_unittest.cc
index 9fa84044b0b95ff1d7fcee2ba6fb1e268087e048..ddcef6666997414b4b52e20b04b59bdb2ecab1f1 100644
--- a/chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc
+++ b/components/web_modal/web_contents_modal_dialog_manager_unittest.cc
@@ -2,24 +2,49 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ui/native_web_contents_modal_dialog_manager.h"
-#include "chrome/browser/ui/web_contents_modal_dialog_manager.h"
-#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "components/web_modal/native_web_contents_modal_dialog_manager.h"
+#include "components/web_modal/web_contents_modal_dialog_manager.h"
#include "content/public/test/test_browser_thread.h"
+#include "content/public/test/test_renderer_host.h"
#include "testing/gtest/include/gtest/gtest.h"
using content::BrowserThread;
+namespace web_modal {
+
+class TestNativeWebContentsModalDialogManager :
+ public NativeWebContentsModalDialogManager {
+ public:
+ TestNativeWebContentsModalDialogManager() {}
+ virtual ~TestNativeWebContentsModalDialogManager() {}
+
+ private:
+ // Overridden from NativeWebContentsModalDialog:
+ virtual void ManageDialog(NativeWebContentsModalDialog dialog) OVERRIDE {}
+ virtual void ShowDialog(NativeWebContentsModalDialog dialog) OVERRIDE {}
+ virtual void HideDialog(NativeWebContentsModalDialog dialog) OVERRIDE {}
+ virtual void CloseDialog(NativeWebContentsModalDialog dialog) OVERRIDE {}
+ virtual void FocusDialog(NativeWebContentsModalDialog dialog) OVERRIDE {}
+ virtual void PulseDialog(NativeWebContentsModalDialog dialog) OVERRIDE {}
+
+ DISALLOW_COPY_AND_ASSIGN(TestNativeWebContentsModalDialogManager);
+};
+
+NativeWebContentsModalDialogManager* WebContentsModalDialogManager::
+CreateNativeManager(
+ NativeWebContentsModalDialogManagerDelegate* native_delegate) {
+ return new TestNativeWebContentsModalDialogManager();
Mike Wittman 2013/05/10 00:03:22 This can probably return a new NativeWebContentsMo
sadrul 2013/05/10 02:59:18 Ah, cool. I didn't actually notice NWCMDMCloseTest
+}
+
class WebContentsModalDialogManagerTest
- : public ChromeRenderViewHostTestHarness {
+ : public content::RenderViewHostTestHarness {
public:
WebContentsModalDialogManagerTest()
- : ChromeRenderViewHostTestHarness(),
- ui_thread_(BrowserThread::UI, &message_loop_) {
+ : ui_thread_(BrowserThread::UI, &message_loop_) {
}
virtual void SetUp() {
- ChromeRenderViewHostTestHarness::SetUp();
+ content::RenderViewHostTestHarness::SetUp();
WebContentsModalDialogManager::CreateForWebContents(web_contents());
}
@@ -77,3 +102,5 @@ TEST_F(WebContentsModalDialogManagerTest, WebContentsModalDialogs) {
test_api.CloseAllDialogs();
EXPECT_EQ(native_manager->close_count, kWindowCount);
}
+
+} // namespace web_modal

Powered by Google App Engine
This is Rietveld 408576698