Issue 13467040: Refactor web contents modal dialog manager tests, add shielding test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13467040: Refactor web contents modal dialog manager tests, add shielding test (Closed)

Created:
7 years, 8 months ago by Mike Wittman

Modified:
7 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor web contents modal dialog manager tests, add shielding test Refactor common web contents modal dialog manager test code to fixture. Add a test for the conditional shielding behavior. BUG=218802

Patch Set 1 #

Patch Set 2 : Add shielding test #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -38 lines)			Patch
	M	chrome/browser/ui/web_contents_modal_dialog_manager_unittest.cc	View	1	2 chunks	+114 lines, -38 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Wittman

Tests for http://crrev.com/13674013. Patch set 1 is the refactoring, patch set 2 adds the shielding ...

7 years, 8 months ago (2013-04-08 21:51:35 UTC) #1

Mike Wittman

7 years, 8 months ago (2013-04-10 16:56:09 UTC) #3

On 2013/04/10 16:27:10, Ben Goodger (Google) wrote:
> lgtm

Thanks! Can you take a look at the code changes corresponding to these tests, at
http://crrev.com/13674013?

Expand Messages | Collapse Messages