Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9214)

Unified Diff: chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc

Issue 1496853002: MD Downloads: fix incognito markers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@thread-bundle
Patch Set: remove DCHECK Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc ('k') | content/browser/browser_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
diff --git a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
index 9d279e4698aba8bc3f075c7268338715846066c0..ced1f8f5db4b6cbda02caf72e0487e737dc89c7a 100644
--- a/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
+++ b/chrome/browser/ui/webui/md_downloads/downloads_list_tracker_unittest.cc
@@ -77,6 +77,7 @@ class TestDownloadsListTracker : public DownloadsListTracker {
: DownloadsListTracker(manager, web_ui, base::Bind(&ShouldShowItem)) {}
~TestDownloadsListTracker() override {}
+ using DownloadsListTracker::IsIncognito;
using DownloadsListTracker::GetItemForTesting;
protected:
@@ -125,6 +126,7 @@ class DownloadsListTrackerTest : public testing::Test {
tracker_.reset(new TestDownloadsListTracker(manager(), web_ui()));
}
+ TestingProfile* profile() { return &profile_; }
content::DownloadManager* manager() { return &manager_; }
content::TestWebUI* web_ui() { return &web_ui_; }
TestDownloadsListTracker* tracker() { return tracker_.get(); }
@@ -271,3 +273,17 @@ TEST_F(DownloadsListTrackerTest, StartExcludesHiddenItems) {
web_ui()->call_data()[0]->function_name());
EXPECT_TRUE(GetIds(web_ui()->call_data()[0]->arg2()).empty());
}
+
+TEST_F(DownloadsListTrackerTest, Incognito) {
+ testing::NiceMock<content::MockDownloadManager> incognito_manager;
+ ON_CALL(incognito_manager, GetBrowserContext()).WillByDefault(Return(
+ TestingProfile::Builder().BuildIncognito(profile())));
+
+ MockDownloadItem item;
+ EXPECT_CALL(item, GetId()).WillRepeatedly(Return(0));
+
+ ON_CALL(incognito_manager, GetDownload(0)).WillByDefault(Return(&item));
+
+ TestDownloadsListTracker tracker(&incognito_manager, web_ui());
+ EXPECT_TRUE(tracker.IsIncognito(item));
+}
« no previous file with comments | « chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc ('k') | content/browser/browser_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698