Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1496843003: Revert of Add transfer buffer support. (Closed)

Created:
5 years ago by egdaniel
Modified:
5 years ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add transfer buffer support. (patchset #9 id:160001 of https://codereview.chromium.org/1490473003/ ) Reason for revert: speculative revert for deps roll failures Original issue's description: > Add transfer buffer support. > > BUG=skia:4604 > > Committed: https://skia.googlesource.com/skia/+/fa498fe12239988578465d0dee69f0d5645bb361 TBR=bsalomon@google.com,jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4604 Committed: https://skia.googlesource.com/skia/+/53c5d5fb795fe04bec050c0583223027c25b839b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -341 lines) Patch
M gyp/gpu.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.h View 3 chunks +0 lines, -18 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
D src/gpu/GrTransferBuffer.h View 1 chunk +0 lines, -76 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.h View 1 chunk +1 line, -11 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.cpp View 4 chunks +3 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 12 chunks +27 lines, -64 lines 0 comments Download
M src/gpu/gl/GrGLIndexBuffer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
D src/gpu/gl/GrGLTransferBuffer.h View 1 chunk +0 lines, -47 lines 0 comments Download
D src/gpu/gl/GrGLTransferBuffer.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
M src/gpu/gl/GrGLVertexBuffer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 9 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
egdaniel
Created Revert of Add transfer buffer support.
5 years ago (2015-12-03 14:32:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496843003/1
5 years ago (2015-12-03 14:32:16 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-03 14:32:27 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/53c5d5fb795fe04bec050c0583223027c25b839b

Powered by Google App Engine
This is Rietveld 408576698