third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp - Issue 1496693005: Update RootFrameViewport::userScroll to distribute scrolls between viewports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

Issue 1496693005: Update RootFrameViewport::userScroll to distribute scrolls between viewports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollableArea.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

index 70d1e4787feddf35de177e6c4a274006293e2e8f..b72c7105ce4976c93be31e0f759ff0eb1fb89603 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

@@ -116,7 +116,7 @@ TEST(ScrollAnimatorTest, Enabled)

ScrollResultOneDimensional result = scrollAnimator->userScroll(HorizontalScrollbar, ScrollByLine, 100, -1);

EXPECT_FALSE(scrollAnimator->hasRunningAnimation());

EXPECT_FALSE(result.didScroll);

- EXPECT_FLOAT_EQ(-100.0, result.unusedScrollDelta);

+ EXPECT_FLOAT_EQ(-1.0f, result.unusedScrollDelta);

result = scrollAnimator->userScroll(HorizontalScrollbar, ScrollByLine, 100, 1);

EXPECT_TRUE(scrollAnimator->hasRunningAnimation());