Make callback arg non-nullable on canvas.toBlob

Make callback arg non-nullable on canvas.toBlob

Recent spec change (https://github.com/whatwg/html/pull/377) says that
toBlob() callback argument should be non-nullable.

BUG=67587
Committed: https://crrev.com/de0c737213ae5df1ae88b666723639820432d19c
Cr-Commit-Position: refs/heads/master@{#364403}

[xlai (Olivia), 2015-12-03 21:59:25]

xlai@chromium.org changed reviewers:
+ junov@chromium.org

[xlai (Olivia), 2015-12-03 21:59:25]

After this change, calling canvas.toBlob(null) will correctly throw such an
error in the JavaScript console: Uncaught TypeError: Failed to execute 'toBlob'
on 'HTMLCanvasElement': The callback provided as parameter 1 is not a function.

[Justin Novosad, 2015-12-03 22:08:36]

This is missing a test. Actually, the original CL was missing a test, and I
missed it. You should have a layout test that tries to call toBlob with null for
the first argument and while you are at it, try to call it with various values
that are of the wrong type. you should also do the same thing for the second
argument.  You need to verify that we throw exceptions and or silently fail or
do implicit conversions in a way that is consistent with the spec.

[Justin Novosad, 2015-12-03 22:13:16]

Here is an example of a test that does this:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Justin Novosad, 2015-12-08 02:09:23]

Description was changed from

==========
Remove nullibility on callback argument in the HTMLCanvasElement.toBlob IDL
according to spec change

Recent spec change (https://github.com/whatwg/html/pull/377) says that
toBlob() callback argument should be non-nullable.

BUG=67587
==========

to

==========
Make callback arg non-nullable on canvas.toBlob

Recent spec change (https://github.com/whatwg/html/pull/377) says that
toBlob() callback argument should be non-nullable.

BUG=67587
==========

[Justin Novosad, 2015-12-08 02:12:28]

lgtm with minor correction.

https://codereview.chromium.org/1496683005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-toBlob-invalid.html
(right):

https://codereview.chromium.org/1496683005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-toBlob-invalid.html:7: <script
src="script-tests/canvas-toBlob-invalid.js"></script>
This is an old way of writing tests. we just put the JS directly in the html
file now.

[xlai (Olivia), 2015-12-10 16:33:11]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2015-12-10 16:33:11]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1496683005/#ps40001
(title: "Small correction")

[commit-bot: I haz the power, 2015-12-10 16:34:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496683005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496683005/40001

[commit-bot: I haz the power, 2015-12-10 18:22:51]

Description was changed from

==========
Make callback arg non-nullable on canvas.toBlob

Recent spec change (https://github.com/whatwg/html/pull/377) says that
toBlob() callback argument should be non-nullable.

BUG=67587
==========

to

==========
Make callback arg non-nullable on canvas.toBlob

Recent spec change (https://github.com/whatwg/html/pull/377) says that
toBlob() callback argument should be non-nullable.

BUG=67587
==========

[commit-bot: I haz the power, 2015-12-10 18:22:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-10 18:23:51]

Description was changed from

==========
Make callback arg non-nullable on canvas.toBlob

Recent spec change (https://github.com/whatwg/html/pull/377) says that
toBlob() callback argument should be non-nullable.

BUG=67587
==========

to

==========
Make callback arg non-nullable on canvas.toBlob

Recent spec change (https://github.com/whatwg/html/pull/377) says that
toBlob() callback argument should be non-nullable.

BUG=67587

Committed: https://crrev.com/de0c737213ae5df1ae88b666723639820432d19c
Cr-Commit-Position: refs/heads/master@{#364403}
==========

[commit-bot: I haz the power, 2015-12-10 18:23:52]

Patchset 3 (id:??) landed as
https://crrev.com/de0c737213ae5df1ae88b666723639820432d19c
Cr-Commit-Position: refs/heads/master@{#364403}

[Noel Gordon, 2015-12-11 01:01:45]

noel@chromium.org changed reviewers:
+ noel@chromium.org

[Noel Gordon, 2015-12-11 01:01:46]

LGTM

https://codereview.chromium.org/1496683005/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-toBlob-invalid.html
(right):

https://codereview.chromium.org/1496683005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-toBlob-invalid.html:12:
shouldThrow("canvas.toBlob(undefined);");
The way it's going, we should add 

shouldThrow("canvas.toBlob(42);");

for posterity :)