third_party/WebKit/Source/core/css/MediaValuesDynamic.h - Issue 1496683002: Avoid rounding down viewport dimensions in Media Queries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/MediaValuesDynamic.h

Issue 1496683002: Avoid rounding down viewport dimensions in Media Queries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix layout test Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/MediaValues.cpp ('K') | « third_party/WebKit/Source/core/css/MediaValuesCached.cpp ('k') | third_party/WebKit/Source/core/css/MediaValuesDynamic.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/MediaValuesDynamic.h

diff --git a/third_party/WebKit/Source/core/css/MediaValuesDynamic.h b/third_party/WebKit/Source/core/css/MediaValuesDynamic.h

index 6a1731c9d2f8adf1ca02ad3ebd637ad193d236bc..a63281c29573b9ff692938b44ec8f67e768fa541 100644

--- a/third_party/WebKit/Source/core/css/MediaValuesDynamic.h

+++ b/third_party/WebKit/Source/core/css/MediaValuesDynamic.h

@@ -20,8 +20,8 @@ public:

bool computeLength(double value, CSSPrimitiveValue::UnitType, int& result) const override;

bool computeLength(double value, CSSPrimitiveValue::UnitType, double& result) const override;

- int viewportWidth() const override;

- int viewportHeight() const override;

+ float viewportWidth() const override;

+ float viewportHeight() const override;

int deviceWidth() const override;

int deviceHeight() const override;

float devicePixelRatio() const override;