third_party/WebKit/Source/core/css/MediaValuesCached.cpp - Issue 1496683002: Avoid rounding down viewport dimensions in Media Queries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/MediaValuesCached.cpp

Issue 1496683002: Avoid rounding down viewport dimensions in Media Queries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix layout test Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/MediaValues.cpp ('K') | « third_party/WebKit/Source/core/css/MediaValuesCached.h ('k') | third_party/WebKit/Source/core/css/MediaValuesDynamic.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/MediaValuesCached.cpp

diff --git a/third_party/WebKit/Source/core/css/MediaValuesCached.cpp b/third_party/WebKit/Source/core/css/MediaValuesCached.cpp

index 3dedbd11e152c4ccac1ab5112bc34900eebc0253..9b3394b7dafdb69434d7f1ec433c36b07a5d9f65 100644

--- a/third_party/WebKit/Source/core/css/MediaValuesCached.cpp

+++ b/third_party/WebKit/Source/core/css/MediaValuesCached.cpp

@@ -100,12 +100,12 @@ bool MediaValuesCached::isSafeToSendToAnotherThread() const

#endif

}

-int MediaValuesCached::viewportWidth() const

+float MediaValuesCached::viewportWidth() const

{

return m_data.viewportWidth;

}

-int MediaValuesCached::viewportHeight() const

+float MediaValuesCached::viewportHeight() const

{

return m_data.viewportHeight;

}

@@ -185,12 +185,12 @@ bool MediaValuesCached::hasValues() const

return true;

}

-void MediaValuesCached::setViewportWidth(int width)

+void MediaValuesCached::setViewportWidth(float width)

{

m_data.viewportWidth = width;

}

-void MediaValuesCached::setViewportHeight(int height)

+void MediaValuesCached::setViewportHeight(float height)

{

m_data.viewportHeight = height;

}