[css-grid] Fix the height computation of grid items with borders

[css-grid] Fix the height computation of grid items with borders

When computing the logical height of grid items for the default
min-height:auto case we were constraning the min-content size using
constrainLogicalHeightByMinMax() instead of
constrainContentLogicalHeightByMinMax(). The problem of using the former is
that we were adding the borders twice.

BUG=560771
Committed: https://crrev.com/ef4104cbb65b5d3d1cf584635a07a1c38f0a4f7a
Cr-Commit-Position: refs/heads/master@{#362948}

[svillar, 2015-12-02 14:19:50]

svillar@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, rego@igalia.com

[svillar, 2015-12-02 14:21:57]

Description was changed from

==========
[css-grid] Fix grid items' with borders height computation

When computing the logical height of grid items for the default
min-height:auto case we were constraning the min-content size using
constrainLogicalHeightByMinMax() instead of
constrainContentLogicalHeightByMinMax(). The problem of using the former is
that we were adding the borders twice.

BUG=560771
==========

to

==========
[css-grid] Fix the height computation of grid items with borders 

When computing the logical height of grid items for the default
min-height:auto case we were constraning the min-content size using
constrainLogicalHeightByMinMax() instead of
constrainContentLogicalHeightByMinMax(). The problem of using the former is
that we were adding the borders twice.

BUG=560771
==========

[jfernandez, 2015-12-02 14:32:18]

LGTM with nits.

https://codereview.chromium.org/1496513002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html
(right):

https://codereview.chromium.org/1496513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html:23:
<div class="grid fixedSizeGrid" data-expected-width="160"
data-expected-height="160">
fixedSizedGrid is not defined..

https://codereview.chromium.org/1496513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html:24:
<div class="item" data-expected-width="150" data-expected-height="150">X</div>
I think we might measure the grid item without the border. I kind of remember
check-layout script provided functions to do so.

[cbiesinger, 2015-12-02 16:00:32]

lgtm

[svillar, 2015-12-03 09:18:31]

Thanks!

https://codereview.chromium.org/1496513002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html
(right):

https://codereview.chromium.org/1496513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html:24:
<div class="item" data-expected-width="150" data-expected-height="150">X</div>
On 2015/12/02 14:32:18, jfernandez wrote:
> I think we might measure the grid item without the border. I kind of remember
> check-layout script provided functions to do so.

Yeah I'll add data-expected-client-* to the tests.

Also as the problem also affect other indefinite sizes I'll add tests for
min-content/max-content/auto.

[svillar, 2015-12-03 09:38:00]

The CQ bit was checked by svillar@igalia.com

[svillar, 2015-12-03 09:38:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, jfernandez@igalia.com
Link to the patchset: https://codereview.chromium.org/1496513002/#ps20001
(title: "Patch for landing")

[commit-bot: I haz the power, 2015-12-03 09:38:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496513002/20001

[commit-bot: I haz the power, 2015-12-03 10:54:32]

Description was changed from

==========
[css-grid] Fix the height computation of grid items with borders 

When computing the logical height of grid items for the default
min-height:auto case we were constraning the min-content size using
constrainLogicalHeightByMinMax() instead of
constrainContentLogicalHeightByMinMax(). The problem of using the former is
that we were adding the borders twice.

BUG=560771
==========

to

==========
[css-grid] Fix the height computation of grid items with borders 

When computing the logical height of grid items for the default
min-height:auto case we were constraning the min-content size using
constrainLogicalHeightByMinMax() instead of
constrainContentLogicalHeightByMinMax(). The problem of using the former is
that we were adding the borders twice.

BUG=560771
==========

[commit-bot: I haz the power, 2015-12-03 10:54:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-03 10:55:12]

Description was changed from

==========
[css-grid] Fix the height computation of grid items with borders 

When computing the logical height of grid items for the default
min-height:auto case we were constraning the min-content size using
constrainLogicalHeightByMinMax() instead of
constrainContentLogicalHeightByMinMax(). The problem of using the former is
that we were adding the borders twice.

BUG=560771
==========

to

==========
[css-grid] Fix the height computation of grid items with borders

When computing the logical height of grid items for the default
min-height:auto case we were constraning the min-content size using
constrainLogicalHeightByMinMax() instead of
constrainContentLogicalHeightByMinMax(). The problem of using the former is
that we were adding the borders twice.

BUG=560771

Committed: https://crrev.com/ef4104cbb65b5d3d1cf584635a07a1c38f0a4f7a
Cr-Commit-Position: refs/heads/master@{#362948}
==========

[commit-bot: I haz the power, 2015-12-03 10:55:13]

Patchset 2 (id:??) landed as
https://crrev.com/ef4104cbb65b5d3d1cf584635a07a1c38f0a4f7a
Cr-Commit-Position: refs/heads/master@{#362948}