third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html - Issue 1496513002: [css-grid] Fix the height computation of grid items with borders

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-with-border-in-fr.html

Issue 1496513002: [css-grid] Fix the height computation of grid items with borders (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <style>

	4 .grid {

	5 display: grid;

	6 grid: 1fr / 1fr;

	7 font: 50px/1 Ahem;

	8 border: 5px dashed magenta;

	9 width: 150px;

	10 height: 150px;

	11 }

	12 .item {

	13 border: 50px solid rgba(0, 255, 250, 0.5);

	14 }

	15 </style>

	16 <script src="../../resources/testharness.js"></script>

	17 <script src="../../resources/testharnessreport.js"></script>

	18 <script src="../../resources/check-layout-th.js"></script>

	19

	20 <body onload="checkLayout('.grid')">

	21 <div id=log></div>

	22

	23 <div class="grid fixedSizeGrid" data-expected-width="160" data-expected-height=" 160">
	jfernandez 2015/12/02 14:32:18 fixedSizedGrid is not defined.. fixedSizedGrid is not defined..
	24 <div class="item" data-expected-width="150" data-expected-height="150">X</di v>
	jfernandez 2015/12/02 14:32:18 I think we might measure the grid item without the I think we might measure the grid item without the border. I kind of remember check-layout script provided functions to do so. svillar 2015/12/03 09:18:30 Yeah I'll add data-expected-client-* to the tests. Show quoted text On 2015/12/02 14:32:18, jfernandez wrote: > I think we might measure the grid item without the border. I kind of remember > check-layout script provided functions to do so. Yeah I'll add data-expected-client-* to the tests. Also as the problem also affect other indefinite sizes I'll add tests for min-content/max-content/auto.
	25 </div>

	26

	27 </body>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »