Chromium Code Reviews| Index: src/objects.cc |
| diff --git a/src/objects.cc b/src/objects.cc |
| index 5bf38b462484ff077c0860f47082afc5fea5534d..af81b17c10187bcd9b942d5a7adc80e832484b4f 100644 |
| --- a/src/objects.cc |
| +++ b/src/objects.cc |
| @@ -2078,9 +2078,6 @@ void HeapObject::HeapObjectShortPrint(std::ostream& os) { // NOLINT |
| case JS_PROXY_TYPE: |
| os << "<JSProxy>"; |
| break; |
| - case JS_FUNCTION_PROXY_TYPE: |
| - os << "<JSFunctionProxy>"; |
| - break; |
| case FOREIGN_TYPE: |
| os << "<Foreign>"; |
| break; |
| @@ -2264,7 +2261,7 @@ void Simd128Value::CopyBits(void* destination) const { |
| String* JSReceiver::class_name() { |
| - if (IsJSFunction() || IsJSFunctionProxy()) { |
| + if (IsJSFunction()) { |
| return GetHeap()->Function_string(); |
| } |
| Object* maybe_constructor = map()->GetConstructor(); |
| @@ -4758,12 +4755,9 @@ MaybeHandle<Context> JSProxy::GetFunctionRealm(Handle<JSProxy> proxy) { |
| THROW_NEW_ERROR(proxy->GetIsolate(), |
| NewTypeError(MessageTemplate::kProxyRevoked), Context); |
| } |
| - |
| - // TODO(verwaest): Get rid of JSFunctionProxies. |
| - Object* target = proxy->IsJSFunctionProxy() |
| - ? JSFunctionProxy::cast(*proxy)->construct_trap() |
| - : proxy->target(); |
| - return JSReceiver::GetFunctionRealm(handle(JSReceiver::cast(target))); |
| + // TODO(cbruni): deal with [[Call]] here? |
|
Toon Verwaest
2015/12/03 11:48:42
DCHECK(target->map()->is_callable());
This is guar
Camillo Bruni
2015/12/03 12:18:26
indeed doesn't matter, removed comment.
|
| + Handle<JSReceiver> target(JSReceiver::cast(proxy->target())); |
| + return JSReceiver::GetFunctionRealm(target); |
| } |
| @@ -12480,7 +12474,6 @@ bool CanSubclassHaveInobjectProperties(InstanceType instance_type) { |
| case JS_FUNCTION_TYPE: |
| return true; |
| - case JS_FUNCTION_PROXY_TYPE: |
| case JS_PROXY_TYPE: |
| case JS_GLOBAL_PROXY_TYPE: |
| case JS_GLOBAL_OBJECT_TYPE: |