Chromium Code Reviews| Index: src/mips64/builtins-mips64.cc |
| diff --git a/src/mips64/builtins-mips64.cc b/src/mips64/builtins-mips64.cc |
| index bf8db9fc64b3dcf2a793d3a03d398128e0aed552..d7d4769bbbcfb810c3c8a3303a58ca0ff39265d1 100644 |
| --- a/src/mips64/builtins-mips64.cc |
| +++ b/src/mips64/builtins-mips64.cc |
| @@ -1697,12 +1697,10 @@ void Builtins::Generate_Call(MacroAssembler* masm, ConvertReceiverMode mode) { |
| __ GetObjectType(a1, t1, t2); |
| __ Jump(masm->isolate()->builtins()->CallFunction(mode), |
| RelocInfo::CODE_TARGET, eq, t2, Operand(JS_FUNCTION_TYPE)); |
| - __ Branch(&non_function, ne, t2, Operand(JS_FUNCTION_PROXY_TYPE)); |
| + __ Branch(&non_function, ne, t2, Operand(JS_PROXY_TYPE)); |
| // 1. Call to function proxy. |
| - // TODO(neis): This doesn't match the ES6 spec for [[Call]] on proxies. |
| - __ ld(a1, FieldMemOperand(a1, JSFunctionProxy::kCallTrapOffset)); |
| - __ AssertNotSmi(a1); |
| + // TODO(neis): Implement [[Call]] on proxies. |
| __ Branch(&non_smi); |
|
Toon Verwaest
2015/12/03 11:48:42
drop the branch
Camillo Bruni
2015/12/03 12:18:26
done
|
| // 2. Call to something else, which might have a [[Call]] internal method (if |
| @@ -1757,13 +1755,12 @@ void Builtins::Generate_ConstructFunction(MacroAssembler* masm) { |
| void Builtins::Generate_ConstructProxy(MacroAssembler* masm) { |
| // ----------- S t a t e ------------- |
| // -- a0 : the number of arguments (not including the receiver) |
| - // -- a1 : the constructor to call (checked to be a JSFunctionProxy) |
| + // -- a1 : the constructor to call (checked to be a JSProxy) |
| // -- a3 : the new target (either the same as the constructor or |
| // the JSFunction on which new was invoked initially) |
| // ----------------------------------- |
| // TODO(neis): This doesn't match the ES6 spec for [[Construct]] on proxies. |
| - __ ld(a1, FieldMemOperand(a1, JSFunctionProxy::kConstructTrapOffset)); |
| __ Jump(masm->isolate()->builtins()->Call(), RelocInfo::CODE_TARGET); |
| } |
| @@ -1787,7 +1784,7 @@ void Builtins::Generate_Construct(MacroAssembler* masm) { |
| __ Jump(masm->isolate()->builtins()->ConstructFunction(), |
| RelocInfo::CODE_TARGET, eq, t2, Operand(JS_FUNCTION_TYPE)); |
| __ Jump(masm->isolate()->builtins()->ConstructProxy(), RelocInfo::CODE_TARGET, |
| - eq, t2, Operand(JS_FUNCTION_PROXY_TYPE)); |
| + eq, t2, Operand(JS_PROXY_TYPE)); |
| // Check if target has a [[Construct]] internal method. |
| __ lbu(t2, FieldMemOperand(t1, Map::kBitFieldOffset)); |