Chromium Code Reviews| Index: src/arm/builtins-arm.cc |
| diff --git a/src/arm/builtins-arm.cc b/src/arm/builtins-arm.cc |
| index fc27816a1875d0fa21119be490833eac69032686..21aa837ba2e49821dbd2581db40aa704c1894cdf 100644 |
| --- a/src/arm/builtins-arm.cc |
| +++ b/src/arm/builtins-arm.cc |
| @@ -1692,13 +1692,11 @@ void Builtins::Generate_Call(MacroAssembler* masm, ConvertReceiverMode mode) { |
| __ CompareObjectType(r1, r4, r5, JS_FUNCTION_TYPE); |
| __ Jump(masm->isolate()->builtins()->CallFunction(mode), |
| RelocInfo::CODE_TARGET, eq); |
| - __ cmp(r5, Operand(JS_FUNCTION_PROXY_TYPE)); |
| + __ cmp(r5, Operand(JS_PROXY_TYPE)); |
| __ b(ne, &non_function); |
| - // 1. Call to function proxy. |
| - // TODO(neis): This doesn't match the ES6 spec for [[Call]] on proxies. |
| - __ ldr(r1, FieldMemOperand(r1, JSFunctionProxy::kCallTrapOffset)); |
| - __ AssertNotSmi(r1); |
| + // 1. Call to Proxy. |
| + // TODO(neis): Implement [[Call]] on proxies. |
| __ b(&non_smi); |
|
Toon Verwaest
2015/12/03 11:48:41
you probably wanted to remove this b(&non_smi), lo
Camillo Bruni
2015/12/03 12:18:26
done
|
| // 2. Call to something else, which might have a [[Call]] internal method (if |
| @@ -1751,13 +1749,12 @@ void Builtins::Generate_ConstructFunction(MacroAssembler* masm) { |
| void Builtins::Generate_ConstructProxy(MacroAssembler* masm) { |
| // ----------- S t a t e ------------- |
| // -- r0 : the number of arguments (not including the receiver) |
| - // -- r1 : the constructor to call (checked to be a JSFunctionProxy) |
| + // -- r1 : the constructor to call (checked to be a JSProxy) |
| // -- r3 : the new target (either the same as the constructor or |
| // the JSFunction on which new was invoked initially) |
| // ----------------------------------- |
| // TODO(neis): This doesn't match the ES6 spec for [[Construct]] on proxies. |
| - __ ldr(r1, FieldMemOperand(r1, JSFunctionProxy::kConstructTrapOffset)); |
| __ Jump(masm->isolate()->builtins()->Call(), RelocInfo::CODE_TARGET); |
| } |
| @@ -1779,7 +1776,7 @@ void Builtins::Generate_Construct(MacroAssembler* masm) { |
| __ CompareObjectType(r1, r4, r5, JS_FUNCTION_TYPE); |
| __ Jump(masm->isolate()->builtins()->ConstructFunction(), |
| RelocInfo::CODE_TARGET, eq); |
| - __ cmp(r5, Operand(JS_FUNCTION_PROXY_TYPE)); |
| + __ cmp(r5, Operand(JS_PROXY_TYPE)); |
| __ Jump(masm->isolate()->builtins()->ConstructProxy(), RelocInfo::CODE_TARGET, |
| eq); |