src/crankshaft/arm/lithium-codegen-arm.cc - Issue 1496503002: [runtime] [proxy] removing JSFunctionProxy and related code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/arm/lithium-codegen-arm.cc

Issue 1496503002: [runtime] [proxy] removing JSFunctionProxy and related code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: doh Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/arm/lithium-codegen-arm.cc

diff --git a/src/crankshaft/arm/lithium-codegen-arm.cc b/src/crankshaft/arm/lithium-codegen-arm.cc

index 7b05ab40d39df1da42714e7ac0d488b216c3ca6c..3c9427ceba8a76de2064796f3d9e8c333c0216b6 100644

--- a/src/crankshaft/arm/lithium-codegen-arm.cc

+++ b/src/crankshaft/arm/lithium-codegen-arm.cc

@@ -5549,8 +5549,8 @@ void LCodeGen::DoForInPrepareMap(LForInPrepareMap* instr) {

__ SmiTst(r0);

DeoptimizeIf(eq, instr, Deoptimizer::kSmi);

- STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_JS_RECEIVER_TYPE);

- __ CompareObjectType(r0, r1, r1, LAST_JS_PROXY_TYPE);

+ STATIC_ASSERT(JS_PROXY_TYPE == FIRST_JS_RECEIVER_TYPE);

+ __ CompareObjectType(r0, r1, r1, JS_PROXY_TYPE);

DeoptimizeIf(le, instr, Deoptimizer::kWrongInstanceType);

Toon Verwaest 2015/12/03 11:48:41 le->eq

Camillo Bruni 2015/12/03 12:18:26 we check for all types so we need the less-equals.

Label use_cache, call_runtime;

« src/arm/builtins-arm.cc ('K') | « src/compiler/js-typed-lowering.cc ('k') | src/crankshaft/arm64/lithium-codegen-arm64.cc » ('j') | src/crankshaft/arm64/lithium-codegen-arm64.cc » ('J')