Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1496283003: Port android_must_copy_system_libraries logic GYP->GN (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
pkotwicz, Yaron
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port android_must_copy_system_libraries logic GYP->GN BUG=559284 Committed: https://crrev.com/2068245252c0142cd7be7f2f8b5896ea877eef53 Cr-Commit-Position: refs/heads/master@{#364057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M base/android/linker/config.gni View 1 chunk +3 lines, -1 line 0 comments Download
M build/config/android/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
agrieve
☁☁☁
5 years ago (2015-12-04 19:31:08 UTC) #2
Yaron
lgtm
5 years ago (2015-12-04 21:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496283003/1
5 years ago (2015-12-08 08:37:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496283003/1
5 years ago (2015-12-09 13:04:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 14:08:49 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-09 14:09:48 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2068245252c0142cd7be7f2f8b5896ea877eef53
Cr-Commit-Position: refs/heads/master@{#364057}

Powered by Google App Engine
This is Rietveld 408576698