runtime/vm/bigint_operations.cc - Issue 14962008: Fix issue 5275: The VM must always generate the most compact form of an integer (Smi, Mint or Bigin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/bigint_operations.cc

Issue 14962008: Fix issue 5275: The VM must always generate the most compact form of an integer (Smi, Mint or Bigin… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/bigint_operations.cc

===================================================================

--- runtime/vm/bigint_operations.cc (revision 22813)

+++ runtime/vm/bigint_operations.cc (working copy)

@@ -664,6 +664,9 @@

int64_t BigintOperations::ToMint(const Bigint& bigint) {

+ if (bigint.IsZero()) {

+ return 0;

+ }

ASSERT(FitsIntoMint(bigint));

int64_t value = AbsToUint64(bigint);

if (bigint.IsNegative()) {

« runtime/lib/double.cc ('K') | « runtime/lib/typed_data.cc ('k') | runtime/vm/isolate.cc » ('j') | runtime/vm/object.h » ('J')