Fix issue 5275: The VM must always generate the most compact form of an integer (Smi, Mint or Bigin…

runtime/lib/double.cc

Index: runtime/lib/double.cc
===================================================================
--- runtime/lib/double.cc	(revision 22813)
+++ runtime/lib/double.cc	(working copy)
@@ -80,10 +80,8 @@
     Exceptions::ThrowByType(Exceptions::kUnsupported, args);
   }
   const Bigint& big = Bigint::Handle(BigintOperations::NewFromDouble(val));
-  if (BigintOperations::FitsIntoSmi(big)) {
-    return BigintOperations::ToSmi(big);
-  } else if (BigintOperations::FitsIntoMint(big)) {
-    return Mint::New(BigintOperations::ToMint(big));
+  if (BigintOperations::FitsIntoMint(big)) {

[Ivan Posva, 2013/05/16 21:46:53]

I find this very confusing. This would be much more readable and easier to
follow if we changed this to:
if (BigintOperations::FitsIntoInt64(big)) {
  return Integer::New(BigintOperations::ToInt64(big));
}

[srdjan, 2013/05/16 21:53:46]

Done in next CL.

+    return Integer::New(BigintOperations::ToMint(big));
   } else {
     return big.raw();
   }