Actually end a ZLib stream with a Z_FINISH marker.

tests/standalone/io/zlib_test.dart

Index: tests/standalone/io/zlib_test.dart
diff --git a/tests/standalone/io/zlib_test.dart b/tests/standalone/io/zlib_test.dart
index 1e83af9d370ae5125307a683b592957e1156706d..6cfa46f20d2a76407279b8a20a8015f535875349 100644
--- a/tests/standalone/io/zlib_test.dart
+++ b/tests/standalone/io/zlib_test.dart
@@ -24,28 +24,8 @@ void testZLibDeflate() {
     controller.add(data);
     controller.close();
   }
-  test(0, [120, 1, 0, 10, 0, 245, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 0, 0,
-           255, 255]);
-  test(1, [120, 1, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(2, [120, 94, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(3, [120, 94, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(4, [120, 94, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(5, [120, 94, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(6, [120, 156, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(-1, [120, 156, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-            255, 255]);
-  test(7, [120, 218, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(8, [120, 218, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(9, [120, 218, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
+  test(6, [120, 156, 99, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 175,
+           0, 46]);

[kustermann, 2013/05/16 10:10:08]

I don't know why your tests didn't catch this issue. These numbers here are
totally opaque to me.

But to make sure we're doing the right thing, I think we should test
- gzipping data with /bin/gzip and trying to unzip with builtin code
- gzipping with builtin code and trying to unzip with /bin/gunzip
- gzipping with builtin code and trying to unzip with builtin code

[Anders Johnsen, 2013/06/11 12:15:15]

The new test is testing that we actually do get a finish chunk. I can't do the
other tests, as they are not platform independent. We do the last test already.

 }
 
 
@@ -58,8 +38,7 @@ void testZLibDeflateEmpty() {
         return buffer;
       })
       .then((data) {
-        print(data);
-        Expect.listEquals([120, 156, 2, 0, 0, 0, 255, 255], data);
+        Expect.listEquals([120, 156, 3, 0, 0, 0, 0, 1], data);
         port.close();
       });
   controller.close();
@@ -76,9 +55,9 @@ void testZLibDeflateGZip() {
         return buffer;
       })
       .then((data) {
-        Expect.equals(26, data.length);
-        Expect.listEquals([98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0,
-                           0, 255, 255],
+        Expect.equals(30, data.length);
+        Expect.listEquals([99, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0,
+                           70, 215, 108, 69, 10, 0, 0, 0],
                           // Skip header, as it can change.
                           data.sublist(10));
         port.close();