Actually end a ZLib stream with a Z_FINISH marker.

tests/standalone/io/zlib_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 import 'dart:async';
 import 'dart:io';
 import 'dart:isolate';
 
 void testZLibDeflate() {
   test(int level, List<int> expected) {
     var port = new ReceivePort();
     var data = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9];
     var controller = new StreamController();
     controller.stream.transform(new ZLibDeflater(gzip: false, level: level))
         .fold([], (buffer, data) {
           buffer.addAll(data);
           return buffer;
         })
         .then((data) {
           Expect.listEquals(expected, data);
           port.close();
         });
     controller.add(data);
     controller.close();
   }
-  test(0, [120, 1, 0, 10, 0, 245, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 0, 0,
-           255, 255]);
-  test(1, [120, 1, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(2, [120, 94, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(3, [120, 94, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(4, [120, 94, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(5, [120, 94, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(6, [120, 156, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(-1, [120, 156, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-            255, 255]);
-  test(7, [120, 218, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(8, [120, 218, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
-  test(9, [120, 218, 98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 0,
-           255, 255]);
+  test(6, [120, 156, 99, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0, 175,
+           0, 46]);

[kustermann, 2013/05/16 10:10:08]

I don't know why your tests didn't catch this issue. These numbers here are
totally opaque to me.

But to make sure we're doing the right thing, I think we should test
- gzipping data with /bin/gzip and trying to unzip with builtin code
- gzipping with builtin code and trying to unzip with /bin/gunzip
- gzipping with builtin code and trying to unzip with builtin code

[Anders Johnsen, 2013/06/11 12:15:15]

The new test is testing that we actually do get a finish chunk. I can't do the
other tests, as they are not platform independent. We do the last test already.

 }
 
 
 void testZLibDeflateEmpty() {
   var port = new ReceivePort();
   var controller = new StreamController();
   controller.stream.transform(new ZLibDeflater(gzip: false, level: 6))
       .fold([], (buffer, data) {
         buffer.addAll(data);
         return buffer;
       })
       .then((data) {
-        print(data);
-        Expect.listEquals([120, 156, 2, 0, 0, 0, 255, 255], data);
+        Expect.listEquals([120, 156, 3, 0, 0, 0, 0, 1], data);
         port.close();
       });
   controller.close();
 }
 
 
 void testZLibDeflateGZip() {
   var port = new ReceivePort();
   var data = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9];
   var controller = new StreamController();
   controller.stream.transform(new ZLibDeflater())
       .fold([], (buffer, data) {
         buffer.addAll(data);
         return buffer;
       })
       .then((data) {
-        Expect.equals(26, data.length);
-        Expect.listEquals([98, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0, 0,
-                           0, 255, 255],
+        Expect.equals(30, data.length);
+        Expect.listEquals([99, 96, 100, 98, 102, 97, 101, 99, 231, 224, 4, 0,
+                           70, 215, 108, 69, 10, 0, 0, 0],
                           // Skip header, as it can change.
                           data.sublist(10));
         port.close();
       });
   controller.add(data);
   controller.close();
 }
 
 void testZLibDeflateInvalidLevel() {
   test2(gzip, level) {
@@ skipping 45 matching lines @@
   }
 }
 
 void main() {
   testZLibDeflate();
   testZLibDeflateEmpty();
   testZLibDeflateGZip();
   testZLibDeflateInvalidLevel();
   testZLibInflate();
 }