Issue 149603007: Fixup SVGSVGElement.createSVGTransformFromMatrix IDL definition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149603007: Fixup SVGSVGElement.createSVGTransformFromMatrix IDL definition (Closed)

Created:
6 years, 10 months ago by fs

Modified:
6 years, 10 months ago

Reviewers:
Nils Barth (inactive), pdr., f(malita), Stephen Chennney

CC:
blink-reviews, krit, arv+blink, fs, watchdog-blink-watchlist_google.com, ed+blinkwatch_opera.com, f(malita), Inactive, gyuyoung.kim_webkit.org, Stephen Chennney, pdr., rwlbuis, kouhei (in TOK), Nils Barth (inactive)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fixup SVGSVGElement.createSVGTransformFromMatrix IDL definition The optional SVGMatrix with a default of undefined is nonsensical, and is not in line with the spec (where the argument is not optional). Remove the 'optional' qualifier and the default value. This aligns behavior with Gecko. (The exception thrown now is about arity, and not about type mismatch as previously.) As a result, the move of the [StrictTypeChecking] attribute to the interface can be completed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167014

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -17 lines)			Patch
M	LayoutTests/svg/dom/undefined-null.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/svg/dom/undefined-null-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGSVGElement.idl	View	3 chunks	+6 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/149603007/1

6 years, 10 months ago (2014-02-12 14:16:40 UTC) #4

Message was sent while issue was closed.

Thanks for fixing this Fredrik!

Expand Messages | Collapse Messages