Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Unified Diff: Source/core/svg/SVGSVGElement.idl

Issue 149603007: Fixup SVGSVGElement.createSVGTransformFromMatrix IDL definition (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/dom/undefined-null-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGSVGElement.idl
diff --git a/Source/core/svg/SVGSVGElement.idl b/Source/core/svg/SVGSVGElement.idl
index a5fe85dd4c95f29f7d8f9afdc88507b59cc98979..00cc64b30bf61d77350fc390702218ab6a308241 100644
--- a/Source/core/svg/SVGSVGElement.idl
+++ b/Source/core/svg/SVGSVGElement.idl
@@ -23,7 +23,7 @@
// TODO: no css::ViewCSS available!
// TODO: no events::DocumentEvent available!
[
- // StrictTypeChecking, // FIXME: createSVGTransformFromMatrix doesn't have [StrictTypeChecking]
+ StrictTypeChecking,
] interface SVGSVGElement : SVGGraphicsElement {
readonly attribute SVGAnimatedLength x;
readonly attribute SVGAnimatedLength y;
@@ -50,14 +50,10 @@
boolean animationsPaused();
float getCurrentTime();
void setCurrentTime(float seconds);
- [StrictTypeChecking] NodeList getIntersectionList(SVGRect rect,
- SVGElement? referenceElement);
- [StrictTypeChecking] NodeList getEnclosureList(SVGRect rect,
- SVGElement? referenceElement);
- [StrictTypeChecking] boolean checkIntersection(SVGElement element,
- SVGRect rect);
- [StrictTypeChecking] boolean checkEnclosure(SVGElement element,
- SVGRect rect);
+ NodeList getIntersectionList(SVGRect rect, SVGElement? referenceElement);
+ NodeList getEnclosureList(SVGRect rect, SVGElement? referenceElement);
+ boolean checkIntersection(SVGElement element, SVGRect rect);
+ boolean checkEnclosure(SVGElement element, SVGRect rect);
void deselectAll();
SVGNumber createSVGNumber();
@@ -67,11 +63,7 @@
SVGMatrix createSVGMatrix();
SVGRect createSVGRect();
SVGTransform createSVGTransform();
- // FIXME: want to turn on [StrictTypeChecking] for interface, but causes
- // createSVGTransformFromMatrix to fail.
- // FIXME: Also, the definition doesn't make sense: [Default=Undefined]
- // requires that the parameter be nullable!
- SVGTransform createSVGTransformFromMatrix([Default=Undefined] optional SVGMatrix matrix);
+ SVGTransform createSVGTransformFromMatrix(SVGMatrix matrix);
Element getElementById([Default=Undefined] optional DOMString elementId);
};
« no previous file with comments | « LayoutTests/svg/dom/undefined-null-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698