Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1495983003: Reland: Enable compositor-thread property trees (Closed)

Created:
5 years ago by ajuma
Modified:
5 years ago
Reviewers:
jaydasika, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, Ian Vollick, achuith+watch_chromium.org, dzhioev+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, blink-reviews, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Enable compositor-thread property trees This relands r360635 (https://codereview.chromium.org/1449143004). This enables compositor-thread property trees for all clients of cc. It also replaces the existing --enable-compositor-property-trees flag with a --disable-compositor-property-trees flag. TBR=piman@chromium.org,jaydasika@chromium.org BUG=481585 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/b6adea99ac09da288ebfa137466727c306bfb9fa Cr-Commit-Position: refs/heads/master@{#363373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M cc/base/switches.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/test/data/background_filter_on_scaled_layer_gl.png View Binary file 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +23 lines, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495983003/1
5 years ago (2015-12-05 16:10:13 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/150908)
5 years ago (2015-12-05 17:50:02 UTC) #4
ajuma
TBRing since this is the same as the CL that previously landed (http://crrev.com/1449143004). The regressions ...
5 years ago (2015-12-05 21:24:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495983003/1
5 years ago (2015-12-05 21:27:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-05 23:28:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495983003/1
5 years ago (2015-12-06 03:18:07 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/150684)
5 years ago (2015-12-06 04:53:57 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495983003/1
5 years ago (2015-12-06 16:26:20 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-06 17:08:26 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495983003/1
5 years ago (2015-12-06 17:14:55 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-06 17:19:27 UTC) #25
commit-bot: I haz the power
5 years ago (2015-12-06 17:20:34 UTC) #27
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b6adea99ac09da288ebfa137466727c306bfb9fa
Cr-Commit-Position: refs/heads/master@{#363373}

Powered by Google App Engine
This is Rietveld 408576698