Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1449143004: Enable compositor-thread property trees (Closed)

Created:
5 years, 1 month ago by ajuma
Modified:
5 years, 1 month ago
Reviewers:
jaydasika, enne (OOO), piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, Ian Vollick, achuith+watch_chromium.org, dzhioev+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, blink-reviews, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable compositor-thread property trees This enables compositor-thread property trees for all clients of cc. It also replaces the existing --enable-compositor-property-trees flag with a --disable-compositor-property-trees flag. BUG=481585 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f626d0b9d0fb2bfde430cf63c5111df7da1fba6f Cr-Commit-Position: refs/heads/master@{#360635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M cc/base/switches.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/test/data/background_filter_on_scaled_layer_gl.png View Binary file 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +23 lines, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ajuma
5 years, 1 month ago (2015-11-19 16:18:47 UTC) #3
jaydasika
lgtm
5 years, 1 month ago (2015-11-19 18:18:24 UTC) #4
ajuma
+piman for content/, ui/compositor/, and chrome/browser/chromeos/login/
5 years, 1 month ago (2015-11-19 18:22:42 UTC) #6
piman
lgtm
5 years, 1 month ago (2015-11-19 18:53:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449143004/1
5 years, 1 month ago (2015-11-19 18:55:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 19:02:00 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f626d0b9d0fb2bfde430cf63c5111df7da1fba6f Cr-Commit-Position: refs/heads/master@{#360635}
5 years, 1 month ago (2015-11-19 19:03:00 UTC) #11
ccameron
5 years, 1 month ago (2015-11-24 02:55:09 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1469733006/ by ccameron@chromium.org.

The reason for reverting is: This is causing overscroll on Mac to fail. Just
using the flag --disable-compositor-property-trees fails to make this go away --
I had to do a manual revert
BUG=559550.

Powered by Google App Engine
This is Rietveld 408576698