Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 149574: Add cookie behavior combobox. (Closed)

Created:
11 years, 5 months ago by mattm
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add cookie behavior combobox. BUG=11507 TEST=Disable cookie saving and try to login to iGoogle. Reenable and try again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20564

Patch Set 1 #

Total comments: 2

Patch Set 2 : use gtk_combo_box_new_text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M chrome/browser/gtk/options/advanced_contents_gtk.cc View 1 6 chunks +50 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mattm
11 years, 5 months ago (2009-07-13 22:14:15 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/149574/diff/1/2 File chrome/browser/gtk/options/advanced_contents_gtk.cc (right): http://codereview.chromium.org/149574/diff/1/2#newcode213 Line 213: gtk_list_store_set( Wow, this is a lot of ...
11 years, 5 months ago (2009-07-13 22:28:32 UTC) #2
mattm
http://codereview.chromium.org/149574/diff/1/2 File chrome/browser/gtk/options/advanced_contents_gtk.cc (right): http://codereview.chromium.org/149574/diff/1/2#newcode213 Line 213: gtk_list_store_set( On 2009/07/13 22:28:32, Evan Martin wrote: > ...
11 years, 5 months ago (2009-07-13 22:39:01 UTC) #3
Evan Martin
11 years, 5 months ago (2009-07-13 22:46:43 UTC) #4
ah, yes, this is more what i was expecting

LGTM

Powered by Google App Engine
This is Rietveld 408576698