Issue 149574: Add cookie behavior combobox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149574: Add cookie behavior combobox. (Closed)

Created:
11 years, 5 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add cookie behavior combobox. BUG=11507 TEST=Disable cookie saving and try to login to iGoogle. Reenable and try again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20564

Patch Set 2 : use gtk_combo_box_new_text #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -2 lines)			Patch
	M	chrome/browser/gtk/options/advanced_contents_gtk.cc	View	1	6 chunks	+50 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM http://codereview.chromium.org/149574/diff/1/2 File chrome/browser/gtk/options/advanced_contents_gtk.cc (right): http://codereview.chromium.org/149574/diff/1/2#newcode213 Line 213: gtk_list_store_set( Wow, this is a lot of ...

11 years, 5 months ago (2009-07-13 22:28:32 UTC) #2

mattm

http://codereview.chromium.org/149574/diff/1/2 File chrome/browser/gtk/options/advanced_contents_gtk.cc (right): http://codereview.chromium.org/149574/diff/1/2#newcode213 Line 213: gtk_list_store_set( On 2009/07/13 22:28:32, Evan Martin wrote: > ...

11 years, 5 months ago (2009-07-13 22:39:01 UTC) #3

ah, yes, this is more what i was expecting

LGTM

Expand Messages | Collapse Messages

Issue 149574: Add cookie behavior combobox. (Closed)

Description

Patch Set 1 #

Patch Set 2 : use gtk_combo_box_new_text #

Messages