Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149573008: Factor out the anchor prefix to easily allow switching to #! (Closed)

Created:
6 years, 10 months ago by Alan Knight
Modified:
6 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dartdoc-viewer.git@master
Visibility:
Public.

Description

Attempt to follow google's scheme for ajax pages, using #! for anchors and supporting _escaped_fragment_ query parameter R=efortuna@google.com Committed: https://github.com/dart-lang/dartdoc-viewer/commit/3b01796

Patch Set 1 #

Patch Set 2 : Accept the basic form (#) but allow the ajax form #

Total comments: 6

Patch Set 3 : Fixes from review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -34 lines) Patch
M client/lib/item.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M client/lib/location.dart View 1 2 4 chunks +27 lines, -4 lines 0 comments Download
M client/pubspec.lock View 4 chunks +4 lines, -4 lines 0 comments Download
M client/web/app.dart View 1 2 3 chunks +24 lines, -6 lines 0 comments Download
M client/web/breadcrumbs.html View 1 chunk +2 lines, -1 line 0 comments Download
M client/web/comment.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M client/web/index.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M client/web/item.html View 1 chunk +2 lines, -1 line 0 comments Download
M client/web/library-panel.html View 1 chunk +2 lines, -1 line 0 comments Download
M client/web/link.dart View 2 chunks +2 lines, -1 line 0 comments Download
M client/web/main.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/web/method.html View 1 chunk +1 line, -1 line 0 comments Download
M client/web/minimap-class.html View 1 chunk +1 line, -1 line 0 comments Download
M client/web/minimap-element.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/web/minimap-element.html View 1 chunk +1 line, -1 line 0 comments Download
M client/web/minimap-library.html View 1 chunk +1 line, -1 line 0 comments Download
M client/web/parameters.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M client/web/search.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/web/type.dart View 2 chunks +2 lines, -1 line 0 comments Download
M client/web/typedef.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M client/web/typedef.html View 1 chunk +1 line, -1 line 0 comments Download
M client/web/variable-heading.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alan Knight
This doesn't really work as it stands, because the expectation is that the escaped_fragment notation ...
6 years, 10 months ago (2014-02-03 20:55:24 UTC) #1
Emily Fortuna
https://chromiumcodereview.appspot.com/149573008/diff/30001/client/lib/location.dart File client/lib/location.dart (right): https://chromiumcodereview.appspot.com/149573008/diff/30001/client/lib/location.dart#newcode43 client/lib/location.dart:43: /// for providing static versions of pages if we ...
6 years, 10 months ago (2014-02-04 01:47:51 UTC) #2
Alan Knight
https://chromiumcodereview.appspot.com/149573008/diff/30001/client/lib/location.dart File client/lib/location.dart (right): https://chromiumcodereview.appspot.com/149573008/diff/30001/client/lib/location.dart#newcode43 client/lib/location.dart:43: /// for providing static versions of pages if we ...
6 years, 10 months ago (2014-02-04 18:08:13 UTC) #3
Emily Fortuna
lgtm
6 years, 10 months ago (2014-02-04 18:46:10 UTC) #4
Alan Knight
6 years, 10 months ago (2014-02-04 18:47:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r3b01796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698