client/web/search.dart - Issue 149573008: Factor out the anchor prefix to easily allow switching to #!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/web/search.dart

Issue 149573008: Factor out the anchor prefix to easily allow switching to #! (Closed) Base URL: https://github.com/dart-lang/dartdoc-viewer.git@master

Patch Set: Fixes from review Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/web/search.dart

diff --git a/client/web/search.dart b/client/web/search.dart

index cd6be62e716e482a504b8f20807856480a85b737..b1b0431fb48a70953126d4dc8edeab2663b19944 100644

--- a/client/web/search.dart

+++ b/client/web/search.dart

@@ -90,7 +90,8 @@ class Search extends PolymerElement {

var newLocation = new LinkableType(refId).location;

var encoded = Uri.encodeFull(newLocation);

viewer.handleLink(encoded);

- window.history.pushState("#$encoded", viewer.title, "#$encoded");

+ window.history.pushState(locationPrefixed(encoded),

+ viewer.title, locationPrefixed(encoded));

searchQuery = "";

results.clear();

}

« no previous file with comments | « client/web/parameters.dart ('k') | client/web/type.dart » ('j') | no next file with comments »