Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: net/cert/ct_serialization_unittest.cc

Issue 149573004: Cleanup: Remove std::string("") usage. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/ct_serialization_unittest.cc
===================================================================
--- net/cert/ct_serialization_unittest.cc (revision 247534)
+++ net/cert/ct_serialization_unittest.cc (working copy)
@@ -94,7 +94,7 @@
base::Time timestamp = base::Time::UnixEpoch() +
base::TimeDelta::FromMilliseconds(1348589665525);
std::string dummy_entry("abc");
- std::string empty_extensions("");
+ std::string empty_extensions();
Nico 2014/01/29 22:15:24 Isn't this a function declaration now? Drop the pa
Lei Zhang 2014/01/29 22:20:16 Done.
// For now, no known failure cases.
std::string encoded;
ASSERT_TRUE(ct::EncodeV1SCTSignedData(
@@ -145,7 +145,7 @@
// Subtracting 4 bytes for signature data (hash & sig algs),
// actual signature data should be 71 bytes.
EXPECT_EQ((size_t) 71, sct->signature.signature_data.size());
- EXPECT_EQ(std::string(""), sct->extensions);
+ EXPECT_TRUE(sct->extensions.empty());
}
TEST_F(CtSerializationTest, FailsDecodingInvalidSignedCertificateTimestamp) {
@@ -162,5 +162,5 @@
ct::DecodeSignedCertificateTimestamp(&invalid_length_sct, &sct));
}
-} // namespace net
+} // namespace net

Powered by Google App Engine
This is Rietveld 408576698