Cleanup: Remove std::string("") usage.

net/cert/ct_serialization_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/ct_serialization.h"
 
 #include <string>
 
 #include "base/file_util.h"
 #include "base/files/file_path.h"
@@ skipping 76 matching lines @@
   std::string expected_prefix("\0\0\0\x2\xCE", 5);
   // Note we use std::string comparison rather than ASSERT_STREQ due
   // to null characters in the buffer.
   EXPECT_EQ(expected_prefix, encoded.substr(0, 5));
 }
 
 TEST_F(CtSerializationTest, EncodesV1SCTSignedData) {
   base::Time timestamp = base::Time::UnixEpoch() +
       base::TimeDelta::FromMilliseconds(1348589665525);
   std::string dummy_entry("abc");
-  std::string empty_extensions("");
+  std::string empty_extensions();

[Nico, 2014/01/29 22:15:24]

Isn't this a function declaration now? Drop the parens?

[Lei Zhang, 2014/01/29 22:20:16]

Done.

   // For now, no known failure cases.
   std::string encoded;
   ASSERT_TRUE(ct::EncodeV1SCTSignedData(
       timestamp,
       dummy_entry,
       empty_extensions,
       &encoded));
   EXPECT_EQ((size_t) 15, encoded.size());
   // Byte 0 is version, byte 1 is signature type
   // Bytes 2-10 are timestamp
@@ skipping 30 matching lines @@
   scoped_refptr<ct::SignedCertificateTimestamp> sct;
   ASSERT_TRUE(ct::DecodeSignedCertificateTimestamp(&encoded_sct, &sct));
   EXPECT_EQ(0, sct->version);
   EXPECT_EQ(ct::GetTestPublicKeyId(), sct->log_id);
   base::Time expected_time = base::Time::UnixEpoch() +
       base::TimeDelta::FromMilliseconds(1365181456089);
   EXPECT_EQ(expected_time, sct->timestamp);
   // Subtracting 4 bytes for signature data (hash & sig algs),
   // actual signature data should be 71 bytes.
   EXPECT_EQ((size_t) 71, sct->signature.signature_data.size());
-  EXPECT_EQ(std::string(""), sct->extensions);
+  EXPECT_TRUE(sct->extensions.empty());
 }
 
 TEST_F(CtSerializationTest, FailsDecodingInvalidSignedCertificateTimestamp) {
   // Invalid version
   base::StringPiece invalid_version_sct("\x2\x0", 2);
   scoped_refptr<ct::SignedCertificateTimestamp> sct;
 
   ASSERT_FALSE(
       ct::DecodeSignedCertificateTimestamp(&invalid_version_sct, &sct));
 
   // Valid version, invalid length (missing data)
   base::StringPiece invalid_length_sct("\x0\xa\xb\xc", 4);
   ASSERT_FALSE(
       ct::DecodeSignedCertificateTimestamp(&invalid_length_sct, &sct));
 }
 
-} // namespace net
+}  // namespace net