Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149573004: Cleanup: Remove std::string("") usage. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -23 lines) Patch
M ash/display/display_manager.cc View 6 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/system/syslogs_provider.cc View 1 2 chunks +9 lines, -8 lines 0 comments Download
M chromeos/network/network_configuration_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/debug_marker_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_serialization_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
thakis: please review OWNERS TBR'd.
6 years, 10 months ago (2014-01-29 21:13:32 UTC) #1
oshima
ash/, chromeos/, chrome/browser/chromeos lgtm
6 years, 10 months ago (2014-01-29 21:25:09 UTC) #2
Nico
lgtm https://codereview.chromium.org/149573004/diff/1/chrome/browser/chromeos/system/syslogs_provider.cc File chrome/browser/chromeos/system/syslogs_provider.cc (right): https://codereview.chromium.org/149573004/diff/1/chrome/browser/chromeos/system/syslogs_provider.cc#newcode64 chrome/browser/chromeos/system/syslogs_provider.cc:64: return key; Hate this change. Early returns FTW! ...
6 years, 10 months ago (2014-01-29 22:15:24 UTC) #3
Lei Zhang
https://codereview.chromium.org/149573004/diff/1/chrome/browser/chromeos/system/syslogs_provider.cc File chrome/browser/chromeos/system/syslogs_provider.cc (right): https://codereview.chromium.org/149573004/diff/1/chrome/browser/chromeos/system/syslogs_provider.cc#newcode64 chrome/browser/chromeos/system/syslogs_provider.cc:64: return key; On 2014/01/29 22:15:24, Nico wrote: > Hate ...
6 years, 10 months ago (2014-01-29 22:20:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/149573004/40001
6 years, 10 months ago (2014-01-29 22:23:37 UTC) #5
Ryan Hamilton
net/ lgtm
6 years, 10 months ago (2014-01-29 22:35:51 UTC) #6
bajones
gpu/ lgtm
6 years, 10 months ago (2014-01-30 00:45:22 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 03:04:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/149573004/40001
6 years, 10 months ago (2014-01-30 03:14:17 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 05:39:01 UTC) #10
Message was sent while issue was closed. 
Change committed as 247844

Powered by Google App Engine
This is Rietveld 408576698