Issue 149559: Make BrowserTest.ThirtyFourTabs not-flaky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149559: Make BrowserTest.ThirtyFourTabs not-flaky (Closed)

Created:
11 years, 5 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make BrowserTest.ThirtyFourTabs not-flaky I converted it to browser_tests framework, so I can just query RenderProcessHost instead of counting "chrome" processes, which apparently induced the flakiness. TEST=Covered by browser_tests. http://crbug.com/16062 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20661

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -29 lines)			Patch
	M	chrome/browser/browser_browsertest.cc	View		2 chunks	+24 lines, -0 lines	0 comments	Download
	M	chrome/browser/browser_uitest.cc	View		1 chunk	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

There is one concern about this change: we're trusting RenderProcessHost's size information. I'm going to ...

11 years, 5 months ago (2009-07-13 19:53:38 UTC) #1

Nicolas Sylvain

I'm not sure I fully understand the concern, so you might want to wait for ...

11 years, 5 months ago (2009-07-14 15:56:35 UTC) #2

LGTM

Expand Messages | Collapse Messages