Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4417)

Unified Diff: chrome/browser/browser_uitest.cc

Issue 149559: Make BrowserTest.ThirtyFourTabs not-flaky (Closed)
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_uitest.cc
diff --git a/chrome/browser/browser_uitest.cc b/chrome/browser/browser_uitest.cc
index 57fc6b5e99aebfd376c7d9578ff061c324c67ebd..cfec07145612708476281d783dccd4fd7c83763a 100644
--- a/chrome/browser/browser_uitest.cc
+++ b/chrome/browser/browser_uitest.cc
@@ -44,35 +44,6 @@ class VisibleBrowserTest : public UITest {
}
};
-// Create 34 tabs and verify that a lot of processes have been created. The
-// exact number of processes depends on the amount of memory. Previously we
-// had a hard limit of 31 processes and this test is mainly directed at
-// verifying that we don't crash when we pass this limit.
-TEST_F(BrowserTest, ThirtyFourTabs) {
- FilePath test_file(test_data_directory_);
- test_file = test_file.AppendASCII("title2.html");
- GURL url(net::FilePathToFileURL(test_file));
- scoped_refptr<BrowserProxy> window(automation()->GetBrowserWindow(0));
- // There is one initial tab.
- for (int ix = 0; ix != 33; ++ix) {
- EXPECT_TRUE(window->AppendTab(url));
- }
- int tab_count = 0;
- EXPECT_TRUE(window->GetTabCount(&tab_count));
- EXPECT_EQ(34, tab_count);
- // Do not test the rest in single process mode.
- if (in_process_renderer())
- return;
- // See browser\renderer_host\render_process_host.cc for the algorithm to
- // decide how many processes to create.
- int process_count = GetBrowserProcessCount();
- if (base::SysInfo::AmountOfPhysicalMemoryMB() >= 2048) {
- EXPECT_GE(process_count, 24);
- } else {
- EXPECT_LE(process_count, 23);
- }
-}
-
#if defined(OS_WIN)
// The browser should quit quickly if it receives a WM_ENDSESSION message.
TEST_F(BrowserTest, WindowsSessionEnd) {
« no previous file with comments | « chrome/browser/browser_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698