Robustify state-transitions in HTMLMediaElement::startDeferredLoad

Robustify state-transitions in HTMLMediaElement::startDeferredLoad

A preload=none load() followed by setting preload != none would try to
transition to ExecuteOnStopDelayingLoadEventTask while in that state
already.

BUG=562535
Committed: https://crrev.com/53c068ead66acd3d858a1a6bb8ef66ccf61bea1d
Cr-Commit-Position: refs/heads/master@{#362735}

[fs, 2015-12-02 13:31:24]

fs@opera.com changed reviewers:
+ philipj@opera.com

[philipj_slow, 2015-12-02 13:41:14]

lgtm w/ nits

https://codereview.chromium.org/1495533002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-preload-none-to-metadata-after-load-crash.html
(right):

https://codereview.chromium.org/1495533002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-preload-none-to-metadata-after-load-crash.html:12:
document.addEventListener('DOMContentLoaded', function() {
Any particular reason to wait for DOMContentLoaded rather than just running the
test right away?

https://codereview.chromium.org/1495533002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-preload-none-to-metadata-after-load-crash.html:14:
video.load();
Setting the src attribute should have implicitly done the same thing as calling
load(), is it needed to trigger the bug?

https://codereview.chromium.org/1495533002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-preload-none-to-metadata-after-load-crash.html:20:
document.body.appendChild(video);
Does it need to be in the document?

[fs, 2015-12-02 14:50:49]

Simplified the test some more.

https://codereview.chromium.org/1495533002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/video-preload-none-to-metadata-after-load-crash.html
(right):

https://codereview.chromium.org/1495533002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-preload-none-to-metadata-after-load-crash.html:14:
video.load();
On 2015/12/02 at 13:41:14, philipj wrote:
> Setting the src attribute should have implicitly done the same thing as
calling load(), is it needed to trigger the bug?

It seems it is, yes.

[philipj_slow, 2015-12-02 14:53:23]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-12-02 14:53:23]

lgtm

[commit-bot: I haz the power, 2015-12-02 14:54:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1495533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1495533002/20001

[fs, 2015-12-02 16:34:28]

The CQ bit was checked by fs@opera.com

[fs, 2015-12-02 16:34:29]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com
Link to the patchset: https://codereview.chromium.org/1495533002/#ps40001
(title: "Fix expectation.")

[commit-bot: I haz the power, 2015-12-02 16:35:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1495533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1495533002/40001

[commit-bot: I haz the power, 2015-12-02 17:12:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-02 17:13:38]

Description was changed from

==========
Robustify state-transitions in HTMLMediaElement::startDeferredLoad

A preload=none load() followed by setting preload != none would try to
transition to ExecuteOnStopDelayingLoadEventTask while in that state
already.

BUG=562535
==========

to

==========
Robustify state-transitions in HTMLMediaElement::startDeferredLoad

A preload=none load() followed by setting preload != none would try to
transition to ExecuteOnStopDelayingLoadEventTask while in that state
already.

BUG=562535

Committed: https://crrev.com/53c068ead66acd3d858a1a6bb8ef66ccf61bea1d
Cr-Commit-Position: refs/heads/master@{#362735}
==========

[commit-bot: I haz the power, 2015-12-02 17:13:39]

Patchset 3 (id:??) landed as
https://crrev.com/53c068ead66acd3d858a1a6bb8ef66ccf61bea1d
Cr-Commit-Position: refs/heads/master@{#362735}