third_party/WebKit/LayoutTests/media/video-preload-none-to-metadata-after-load-crash.html - Issue 1495533002: Robustify state-transitions in HTMLMediaElement::startDeferredLoad

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-preload-none-to-metadata-after-load-crash.html

Issue 1495533002: Robustify state-transitions in HTMLMediaElement::startDeferredLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Setting preload=metadata after calling load() w/ preload=none</title>

	3 <script src="media-file.js"></script>

	4 <p>PASS if no crash in Debug.</p>

	5 <script>

	6 if (window.testRunner) {

	7 testRunner.waitUntilDone();

	8 testRunner.dumpAsText();

	9 }

	10 var video = document.createElement('video');

	11 video.preload = "none";

	12 document.addEventListener('DOMContentLoaded', function() {
	philipj_slow 2015/12/02 13:41:14 Any particular reason to wait for DOMContentLoaded Any particular reason to wait for DOMContentLoaded rather than just running the test right away?
	13 video.src = findMediaFile('video', 'content/test');

	14 video.load();
	philipj_slow 2015/12/02 13:41:14 Setting the src attribute should have implicitly d Setting the src attribute should have implicitly done the same thing as calling load(), is it needed to trigger the bug? fs 2015/12/02 14:50:49 It seems it is, yes. Show quoted text On 2015/12/02 at 13:41:14, philipj wrote: > Setting the src attribute should have implicitly done the same thing as calling load(), is it needed to trigger the bug? It seems it is, yes.
	15 video.preload = "metadata";

	16

	17 if (window.testRunner)

	18 testRunner.notifyDone();

	19 });

	20 document.body.appendChild(video);
	philipj_slow 2015/12/02 13:41:14 Does it need to be in the document? Does it need to be in the document?
	21 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/video-preload-none-to-metadata-after-load-crash-expected.txt » ('j') | no next file with comments »