DescriptionRemove the concept of threading from ProxyService, and move it into the ProxyResolver dependency.
ProxyResolver may now complete requests asynchronously, and is defined to handle multiple requests.
The code from ProxyService that queued requests onto the single PAC thread has moved into SingleThreadedProxyResolver.
This refactor lays the groundwork for:
(1) http://crbug.com/11746 -- Run PAC proxy resolving out of process.
(Can inject an IPC bridge implementation of ProxyResolver)
(2) http://crbug.com/11079 -- Run PAC proxy resolving on multiple threads.
(Can implement a MultithreadedProxyResolver type class; still complications around v8 threadsafety though).
BUG=http://crbug.com/11746, http://crbug.com/11079
TEST=existing unit-tests.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21631
Patch Set 1 #Patch Set 2 : Add two missing files to the CL #Patch Set 3 : Fix some style nits #Patch Set 4 : Moar tests. #Patch Set 5 : Fix a header ordering #
Total comments: 53
Patch Set 6 : Address willchan's comments #Patch Set 7 : Add a missing SetPacScriptByUrl() implementation #
Total comments: 24
Patch Set 8 : address willchan's comments #
Total comments: 6
Patch Set 9 : Sync #Patch Set 10 : Address willchan's comments #Patch Set 11 : Add missing header for mac #
Messages
Total messages: 9 (0 generated)
|