Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: net/proxy/proxy_resolver_v8.h

Issue 149525: Remove the concept of threading from ProxyService, and move it into the Proxy... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Add missing header for mac Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_resolver_perftest.cc ('k') | net/proxy/proxy_resolver_v8.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver_v8.h
===================================================================
--- net/proxy/proxy_resolver_v8.h (revision 21630)
+++ net/proxy/proxy_resolver_v8.h (working copy)
@@ -43,13 +43,14 @@
// is destroyed.
explicit ProxyResolverV8(JSBindings* custom_js_bindings);
- ~ProxyResolverV8();
+ virtual ~ProxyResolverV8();
// ProxyResolver implementation:
- virtual int GetProxyForURL(const GURL& query_url,
- const GURL& /*pac_url*/,
- ProxyInfo* results);
- virtual void SetPacScript(const std::string& bytes);
+ virtual int GetProxyForURL(const GURL& url,
+ ProxyInfo* results,
+ CompletionCallback* /*callback*/,
+ RequestHandle* /*request*/);
+ virtual void CancelRequest(RequestHandle request);
JSBindings* js_bindings() const { return js_bindings_.get(); }
@@ -71,8 +72,12 @@
private:
// Context holds the Javascript state for the most recently loaded PAC
// script. It corresponds with the data from the last call to
- // SetPacScript().
+ // SetPacScriptByDataInternal().
class Context;
+
+ // ProxyResolver implementation:
+ virtual void SetPacScriptByDataInternal(const std::string& bytes);
+
scoped_ptr<Context> context_;
scoped_ptr<JSBindings> js_bindings_;
« no previous file with comments | « net/proxy/proxy_resolver_perftest.cc ('k') | net/proxy/proxy_resolver_v8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698