Issue 1495233004: [Extensions] Add allow-modals to the default sandbox CSP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1495233004: [Extensions] Add allow-modals to the default sandbox CSP (Closed)

Created:
5 years ago by Ken Rockot(use gerrit already)

Modified:
5 years ago

Reviewers:
Devlin

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

[Extensions] Add allow-modals to the default sandbox CSP BUG=560226 R=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/1482243004 Cr-Commit-Position: refs/heads/master@{#362509} (cherry picked from commit dbadb4c822a748211b634f4807e65e8ef9fc0b93) Committed: https://chromium.googlesource.com/chromium/src/+/eb90a79f2b2291ba93438c8d737d0405a2855095

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	extensions/common/manifest_handlers/sandboxed_page_info.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Ken Rockot(use gerrit already)

5 years ago (2015-12-04 23:08:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
eb90a79f2b2291ba93438c8d737d0405a2855095 (tree was closed).