Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1482243004: [Extensions] Add allow-modals to the default sandbox CSP (Closed)

Created:
5 years ago by Ken Rockot(use gerrit already)
Modified:
5 years ago
Reviewers:
Devlin
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Add allow-modals to the default sandbox CSP BUG=560226 R=rdevlin.cronin@chromium.org Committed: https://crrev.com/dbadb4c822a748211b634f4807e65e8ef9fc0b93 Cr-Commit-Position: refs/heads/master@{#362509}

Patch Set 1 #

Patch Set 2 : Update unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/manifest_handlers/sandboxed_page_info.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
Please take a look. As explained in the bug, allow-modals is now required for sandboxed ...
5 years ago (2015-12-01 14:05:39 UTC) #1
Devlin
lgtm
5 years ago (2015-12-01 17:30:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482243004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482243004/20001
5 years ago (2015-12-01 21:07:00 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-01 21:45:41 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-01 21:46:23 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dbadb4c822a748211b634f4807e65e8ef9fc0b93
Cr-Commit-Position: refs/heads/master@{#362509}

Powered by Google App Engine
This is Rietveld 408576698