Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 149513007: [Mac] The GAIA profile photo should be resized in the Users controller menu (Closed)

Created:
6 years, 10 months ago by noms (inactive)
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] The GAIA profile photo should be resized in the Users controller menu BUG=327087 TEST=Start chrome with the --google-profile-info flag, and a signed in user. If you choose 'Users' for the top menu bar, the signed in user's profile photo should be the same size as the other items. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247952

Patch Set 1 #

Total comments: 4

Patch Set 2 : alexei review #

Total comments: 4

Patch Set 3 : alexei nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/browser/ui/cocoa/profile_menu_controller.mm View 1 2 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
noms (inactive)
6 years, 10 months ago (2014-01-29 20:20:27 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/149513007/diff/1/chrome/browser/profiles/profile_info_util.h File chrome/browser/profiles/profile_info_util.h (right): https://codereview.chromium.org/149513007/diff/1/chrome/browser/profiles/profile_info_util.h#newcode18 chrome/browser/profiles/profile_info_util.h:18: bool AvatarIconNeedsResizing(const gfx::Image& image); I am guessing this is ...
6 years, 10 months ago (2014-01-29 20:23:56 UTC) #2
noms (inactive)
https://codereview.chromium.org/149513007/diff/1/chrome/browser/profiles/profile_info_util.h File chrome/browser/profiles/profile_info_util.h (right): https://codereview.chromium.org/149513007/diff/1/chrome/browser/profiles/profile_info_util.h#newcode18 chrome/browser/profiles/profile_info_util.h:18: bool AvatarIconNeedsResizing(const gfx::Image& image); I don't really know where ...
6 years, 10 months ago (2014-01-29 20:31:29 UTC) #3
Alexei Svitkine (slow)
LGTM % comments https://codereview.chromium.org/149513007/diff/20001/chrome/browser/ui/cocoa/profile_menu_controller.mm File chrome/browser/ui/cocoa/profile_menu_controller.mm (right): https://codereview.chromium.org/149513007/diff/20001/chrome/browser/ui/cocoa/profile_menu_controller.mm#newcode137 chrome/browser/ui/cocoa/profile_menu_controller.mm:137: itemIcon.Height() > profiles::kAvatarIconHeight) Nit: add {} ...
6 years, 10 months ago (2014-01-29 21:08:25 UTC) #4
noms (inactive)
https://codereview.chromium.org/149513007/diff/20001/chrome/browser/ui/cocoa/profile_menu_controller.mm File chrome/browser/ui/cocoa/profile_menu_controller.mm (right): https://codereview.chromium.org/149513007/diff/20001/chrome/browser/ui/cocoa/profile_menu_controller.mm#newcode137 chrome/browser/ui/cocoa/profile_menu_controller.mm:137: itemIcon.Height() > profiles::kAvatarIconHeight) On 2014/01/29 21:08:25, Alexei Svitkine wrote: ...
6 years, 10 months ago (2014-01-29 22:14:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/149513007/40001
6 years, 10 months ago (2014-01-29 22:23:23 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 03:04:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/149513007/40001
6 years, 10 months ago (2014-01-30 03:13:50 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 13:48:21 UTC) #9
Message was sent while issue was closed.
Change committed as 247952

Powered by Google App Engine
This is Rietveld 408576698