[Mac] The GAIA profile photo should be resized in the Users controller menu

[Mac] The GAIA profile photo should be resized in the Users controller menu

BUG=327087
TEST=Start chrome with the --google-profile-info flag, and a signed in
user. If you choose 'Users' for the top menu bar, the signed in user's
profile photo should be the same size as the other items.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247952

[Alexei Svitkine (slow), 2014-01-29 20:23:56]

https://codereview.chromium.org/149513007/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_info_util.h (right):

https://codereview.chromium.org/149513007/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_info_util.h:18: bool
AvatarIconNeedsResizing(const gfx::Image& image);
I am guessing this is here because you're going to re-use this logic from other
UI code?

If so, why not make the shared function actually return a correctly sized image?
(i.e. either the image or one that's correctly sized).

https://codereview.chromium.org/149513007/diff/1/chrome/browser/ui/cocoa/prof...
File chrome/browser/ui/cocoa/profile_menu_controller.mm (right):

https://codereview.chromium.org/149513007/diff/1/chrome/browser/ui/cocoa/prof...
chrome/browser/ui/cocoa/profile_menu_controller.mm:135: // a signed-in user
using the GAIA profile photo.
Nit: Close your parenthesis!

[noms (inactive), 2014-01-29 20:31:29]

https://codereview.chromium.org/149513007/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_info_util.h (right):

https://codereview.chromium.org/149513007/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_info_util.h:18: bool
AvatarIconNeedsResizing(const gfx::Image& image);
I don't really know where I would reuse it. There's not a lot of consistency in
how the images are resized (with or without a border), so I couldn't make a
decision as to which would be needed in the "general" case. I'm going to punt
this api enthusiasm and just do the resize-needed check in the controller. :)

On 2014/01/29 20:23:56, Alexei Svitkine wrote:
> I am guessing this is here because you're going to re-use this logic from
other
> UI code?
> 
> If so, why not make the shared function actually return a correctly sized
image?
> (i.e. either the image or one that's correctly sized).

https://codereview.chromium.org/149513007/diff/1/chrome/browser/ui/cocoa/prof...
File chrome/browser/ui/cocoa/profile_menu_controller.mm (right):

https://codereview.chromium.org/149513007/diff/1/chrome/browser/ui/cocoa/prof...
chrome/browser/ui/cocoa/profile_menu_controller.mm:135: // a signed-in user
using the GAIA profile photo.
GAH. Done.
On 2014/01/29 20:23:56, Alexei Svitkine wrote:
> Nit: Close your parenthesis!

[Alexei Svitkine (slow), 2014-01-29 21:08:25]

LGTM % comments

https://codereview.chromium.org/149513007/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/profile_menu_controller.mm (right):

https://codereview.chromium.org/149513007/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profile_menu_controller.mm:137: itemIcon.Height() >
profiles::kAvatarIconHeight)
Nit: add {}

https://codereview.chromium.org/149513007/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profile_menu_controller.mm:138: itemIcon =
profiles::GetAvatarIconForWebUI(itemIcon, true);
Maybe add DCHECKs that the new size meets the criteria?

[noms (inactive), 2014-01-29 22:14:19]

https://codereview.chromium.org/149513007/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/profile_menu_controller.mm (right):

https://codereview.chromium.org/149513007/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profile_menu_controller.mm:137: itemIcon.Height() >
profiles::kAvatarIconHeight)
On 2014/01/29 21:08:25, Alexei Svitkine wrote:
> Nit: add {}

Done.

https://codereview.chromium.org/149513007/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/profile_menu_controller.mm:138: itemIcon =
profiles::GetAvatarIconForWebUI(itemIcon, true);
On 2014/01/29 21:08:25, Alexei Svitkine wrote:
> Maybe add DCHECKs that the new size meets the criteria?

Done.

[commit-bot: I haz the power, 2014-01-29 22:23:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/149513007/40001

[commit-bot: I haz the power, 2014-01-30 03:04:44]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-30 03:13:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/149513007/40001

[commit-bot: I haz the power, 2014-01-30 13:48:21]

Change committed as 247952