[Mac] The GAIA profile photo should be resized in the Users controller menu

chrome/browser/profiles/profile_info_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_INFO_UTIL_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_INFO_UTIL_H_
 
 #include "ui/gfx/image/image.h"
 
 namespace profiles {
 
 extern const int kAvatarIconWidth;
 extern const int kAvatarIconHeight;
 extern const int kAvatarIconPadding;
 
+// Return whether or not |image| needs to be resized to a suitable size
+// as given by kAvatarIconWidth and kAvatarIconHeight.
+bool AvatarIconNeedsResizing(const gfx::Image& image);

[Alexei Svitkine (slow), 2014/01/29 20:23:56]

I am guessing this is here because you're going to re-use this logic from other
UI code?

If so, why not make the shared function actually return a correctly sized image?
(i.e. either the image or one that's correctly sized).

[noms (inactive), 2014/01/29 20:31:29]

I don't really know where I would reuse it. There's not a lot of consistency in
how the images are resized (with or without a border), so I couldn't make a
decision as to which would be needed in the "general" case. I'm going to punt
this api enthusiasm and just do the resize-needed check in the controller. :)

On 2014/01/29 20:23:56, Alexei Svitkine wrote:

+
 // Returns a version of |image| of a specific size and with a grey border.
 // Note that no checks are done on the width/height so make sure they're
 // reasonable values; in the range of 16-256 is probably best.
 gfx::Image GetSizedAvatarIconWithBorder(const gfx::Image& image,
                                         bool is_rectangle,
                                         int width, int height);
 
 // Returns a version of |image| suitable for use in menus.
 gfx::Image GetAvatarIconForMenu(const gfx::Image& image,
                                 bool is_rectangle);
 
 // Returns a version of |image| suitable for use in WebUI.
 gfx::Image GetAvatarIconForWebUI(const gfx::Image& image,
                                  bool is_rectangle);
 
 // Returns a version of |image| suitable for use in title bars. The returned
 // image is scaled to fit |dst_width| and |dst_height|.
 gfx::Image GetAvatarIconForTitleBar(const gfx::Image& image,
                                     bool is_rectangle,
                                     int dst_width,
                                     int dst_height);
 
 }  // namespace profiles
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_INFO_UTIL_H_