Stacked floats with shape-outside should allow inline content to interact with the non-outermost fl…

Stacked floats with shape-outside should allow inline content to interact with the non-outermost float

Make inline content interact with stacked floats with shape-outside per
the spec. This means that content can interact with floats on the line
that are not the outermost float.

This refactors ComputeFloatOffsetAdapter into a superclass and two
subclasses: one adaptor for determining the offset for float layout, and
one for determining the offset for inline layout.

The logic in LineWidth::shrinkAvailableWidthForNewFloatIfNeeded has been
updated to handle stacked floats with shape-outside properly and has
been considerably simplified in the process. It was previously doing a
whole bunch of unnecessary work.

This is a port from WebKit of http://trac.webkit.org/changeset/162217

BUG=249140
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168155

[Bem Jones-Bey (adobe), 2014-01-30 19:07:04]

PTAL.

As a carrot, I think this makes all floats a bit faster. ;-)

[eseidel, 2014-01-30 19:19:28]

This may be a little while.  leviw is OOO today through next Tues (at which
point he and I will be on TOK time).

[leviw_travelin_and_unemployed, 2014-02-10 05:09:30]

On 2014/01/30 19:19:28, eseidel wrote:
> This may be a little while.  leviw is OOO today through next Tues (at which
> point he and I will be on TOK time).

I want to be a better reviewer for this code, but haven't quite tracked all the
work Eric and you did on floats, and in general don't have a totally firm grasp
on shapes. I get back from Tokyo next week... Would you be available to sit down
with me in person and help me understand this code better?

[Bem Jones-Bey (adobe), 2014-02-10 15:37:28]

On 2014/02/10 05:09:30, Levi wrote:
> On 2014/01/30 19:19:28, eseidel wrote:
> > This may be a little while.  leviw is OOO today through next Tues (at which
> > point he and I will be on TOK time).
> 
> I want to be a better reviewer for this code, but haven't quite tracked all
the
> work Eric and you did on floats, and in general don't have a totally firm
grasp
> on shapes. I get back from Tokyo next week... Would you be available to sit
down
> with me in person and help me understand this code better?

Yes, I'm happy to do that. Drop me a line when you get back, and we can schedule
something.

[leviw_travelin_and_unemployed, 2014-02-27 21:59:05]

lgtm

https://codereview.chromium.org/149513005/diff/1/Source/core/rendering/line/L...
File Source/core/rendering/line/LineWidth.cpp (right):

https://codereview.chromium.org/149513005/diff/1/Source/core/rendering/line/L...
Source/core/rendering/line/LineWidth.cpp:97: else // If the line doesn't overlap
the shape, then we need to act as if this float didn't exist.
I could go so far as to suggest linking to the spec here, but I appreciate the
comment.

[Bem Jones-Bey (adobe), 2014-02-27 23:25:36]

The CQ bit was checked by bjonesbe@adobe.com

[commit-bot: I haz the power, 2014-02-27 23:25:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/149513005/80001

[commit-bot: I haz the power, 2014-02-28 01:09:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/149513005/80001

[commit-bot: I haz the power, 2014-02-28 02:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 02:33:25]

Retried try job too often on linux_blink for step(s) blink_heap_unittests,
blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests,
webkit_unit_tests, wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[Bem Jones-Bey (adobe), 2014-02-28 16:45:30]

The CQ bit was checked by bjonesbe@adobe.com

[commit-bot: I haz the power, 2014-02-28 16:45:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/149513005/100001

[commit-bot: I haz the power, 2014-02-28 19:04:03]

Change committed as 168155