Fix a -Wunused-function warning with win/clang.

Fix a -Wunused-function warning with win/clang.

BUG=82385
Committed: https://chromium.googlesource.com/native_client/src/native_client/+/542476ec5065a443e4644243fb8ee15cd4f4b9d8

[Nico, 2015-12-05 02:43:59]

thakis@chromium.org changed reviewers:
+ bradnelson@chromium.org

[Roland McGrath, 2015-12-05 11:07:46]

mcgrathr@chromium.org changed reviewers:
+ mcgrathr@chromium.org

[Roland McGrath, 2015-12-05 11:07:46]

https://codereview.chromium.org/1495033006/diff/1/src/trusted/platform_qualif...
File src/trusted/platform_qualify/arch/x86/vcpuid.c (right):

https://codereview.chromium.org/1495033006/diff/1/src/trusted/platform_qualif...
src/trusted/platform_qualify/arch/x86/vcpuid.c:493: #if !(NACL_WINDOWS &&
(NACL_BUILD_SUBARCH == 64))
It would be better to factor out the caller code that is under the same #if
condition below into a subroutine that can go inside this same #if block, with a
stub function in the #else block so there does not need to be yet another
instance of this same #if condition below.

[Nico, 2015-12-05 15:35:38]

https://codereview.chromium.org/1495033006/diff/1/src/trusted/platform_qualif...
File src/trusted/platform_qualify/arch/x86/vcpuid.c (right):

https://codereview.chromium.org/1495033006/diff/1/src/trusted/platform_qualif...
src/trusted/platform_qualify/arch/x86/vcpuid.c:493: #if !(NACL_WINDOWS &&
(NACL_BUILD_SUBARCH == 64))
On 2015/12/05 11:07:46, Roland McGrath wrote:
> It would be better to factor out the caller code that is under the same #if
> condition below into a subroutine that can go inside this same #if block, with
a
> stub function in the #else block so there does not need to be yet another
> instance of this same #if condition below.

Done, but seems somewhat out of scope for this particular cl maybe.

[Nico, 2015-12-07 18:10:51]

ping?

[Roland McGrath, 2015-12-07 19:28:46]

lgtm

[Nico, 2015-12-07 19:29:04]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-12-07 19:29:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1495033006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1495033006/20001

[commit-bot: I haz the power, 2015-12-07 19:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 19:51:09]

Try jobs failed on following builders:
  nacl-win64_newlib_dbg on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-win64_newlib_dbg/bui...)

[Nico, 2015-12-07 19:51:45]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-12-07 19:51:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1495033006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1495033006/20001

[commit-bot: I haz the power, 2015-12-07 20:25:03]

Description was changed from

==========
Fix a -Wunused-function warning with win/clang.

BUG=82385
==========

to

==========
Fix a -Wunused-function warning with win/clang.

BUG=82385

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/542476ec5...
==========

[commit-bot: I haz the power, 2015-12-07 20:25:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/542476ec5...