Fix a -Wunused-function warning with win/clang.

src/trusted/platform_qualify/arch/x86/vcpuid.c

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * vcpuid.c
  *
  * Verify correctness of CPUID implementation.
@@ skipping 472 matching lines @@
     return 0;
   } else {
     printf("no %s\n", s);
     return 1;
   }
 }
 #else
 # error Please specify platform as NACL_LINUX, NACL_OSX or NACL_WINDOWS
 #endif
 
+#if !(NACL_WINDOWS && (NACL_BUILD_SUBARCH == 64))

[Roland McGrath, 2015/12/05 11:07:46]

It would be better to factor out the caller code that is under the same #if
condition below into a subroutine that can go inside this same #if block, with a
stub function in the #else block so there does not need to be yet another
instance of this same #if condition below.

[Nico, 2015/12/05 15:35:38]

Done, but seems somewhat out of scope for this particular cl maybe.

 static int DoCPUFeatureTest(NaClCPUFeaturesX86 *features,
                             NaClCPUFeatureX86ID id,
                             int (*thetest)(void)) {
   if (NaClGetCPUFeatureX86(features, id))
     return DoTest(thetest, NaClGetCPUFeatureX86Name(id));
   else
     return 0;
 }
+#endif  /* 64-bit Windows */
 
 static void PrintFail(const char *why) {
   fprintf(stderr, "ERROR: %s.\n", why);
   fprintf(stderr, "Google Native Client cannot continue.\n");
 }
 
 #define TEST_NEGATIVE_CASE 0
 int CPUIDImplIsValid(void) {
   NaClCPUFeaturesX86 cpuf;
   NaClGetCurrentCPUFeaturesX86((NaClCPUFeatures *) &cpuf);
@@ skipping 44 matching lines @@
     if (rcode != 0) {
       PrintFail("CPUID not implemented correctly.");
       return 0;
     }
   }
 #endif  /* 64-bit Windows */
 
   printf("[CPUID implementation looks okay]\n");
   return 1;
 }