Remove common EventConverterOzone class & move to EventConverterEvdev

Remove common EventConverterOzone class & move to EventConverterEvdev

There's no need for this interface in common code; the DispatchEvent
function can be moved onto EventFactoryOzone.

We're still relying on this class in the evdev implementation for

- unifying storage of TouchEventConverter & KeyEventConverter instances
- overriding event dispatching in the tests

Therefore, move it into evdev as EventConverterEvdev.

R=rjkroege
TEST=events_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247997

[rjkroege, 2014-01-29 17:01:43]

lgtm

https://codereview.chromium.org/149503003/diff/1/ui/events/ozone/event_factor...
File ui/events/ozone/event_factory_ozone.cc (right):

https://codereview.chromium.org/149503003/diff/1/ui/events/ozone/event_factor...
ui/events/ozone/event_factory_ozone.cc:19: TRACE_EVENT1("ozone",
"DispatchEventHelper", "type", key->type());
it is worth perhaps expanding the text in this trace to make it easier to
understand that this function is the highest stack frame of one particular
event's handling

nit: and perhaps you could add a TRACE_EVENT after the Dispatch itself?

[spang, 2014-01-29 17:58:55]

https://codereview.chromium.org/149503003/diff/1/ui/events/ozone/event_factor...
File ui/events/ozone/event_factory_ozone.cc (right):

https://codereview.chromium.org/149503003/diff/1/ui/events/ozone/event_factor...
ui/events/ozone/event_factory_ozone.cc:19: TRACE_EVENT1("ozone",
"DispatchEventHelper", "type", key->type());
On 2014/01/29 17:01:43, rjkroege wrote:
> it is worth perhaps expanding the text in this trace to make it easier to
> understand that this function is the highest stack frame of one particular
> event's handling
> 

Agree the name could be clearer. Any ideas?

DispatchEventTask?

> nit: and perhaps you could add a TRACE_EVENT after the Dispatch itself?

The event lasts until the scope closes. So it covers the dispatch already (and
logs two messages).

[rjkroege, 2014-01-29 21:08:06]

On 2014/01/29 17:58:55, spang wrote:
>
https://codereview.chromium.org/149503003/diff/1/ui/events/ozone/event_factor...
> File ui/events/ozone/event_factory_ozone.cc (right):
> 
>
https://codereview.chromium.org/149503003/diff/1/ui/events/ozone/event_factor...
> ui/events/ozone/event_factory_ozone.cc:19: TRACE_EVENT1("ozone",
> "DispatchEventHelper", "type", key->type());
> On 2014/01/29 17:01:43, rjkroege wrote:
> > it is worth perhaps expanding the text in this trace to make it easier to
> > understand that this function is the highest stack frame of one particular
> > event's handling
> > 
> 
> Agree the name could be clearer. Any ideas?
> 
> DispatchEventTask?

Sure. Sounds good to me.

> 
> > nit: and perhaps you could add a TRACE_EVENT after the Dispatch itself?
> 
> The event lasts until the scope closes. So it covers the dispatch already (and
> logs two messages).

[commit-bot: I haz the power, 2014-01-30 15:02:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/spang@chromium.org/149503003/10015

[commit-bot: I haz the power, 2014-01-30 18:10:57]

Change committed as 247997

[commit-bot: I haz the power, 2014-01-30 18:11:30]

CQ bit was unchecked on CL. Ignoring.