Fix the new Mojo EDK's mojo_system_unittests to pass in release builds and also on Linux.

Fix the new Mojo EDK's mojo_system_unittests to pass in release builds and also on Linux.

BUG=556259
Committed: https://crrev.com/4bb42cddc22e6d4d25bf70525c5c094d0b67c691
Cr-Commit-Position: refs/heads/master@{#363018}

[jam, 2015-12-03 03:42:35]

jam@chromium.org changed reviewers:
+ yzshen@chromium.org

[jam, 2015-12-03 03:42:36]

https://codereview.chromium.org/1494863002/diff/1/mojo/edk/embedder/simple_pl...
File mojo/edk/embedder/simple_platform_shared_buffer_unittest.cc (right):

https://codereview.chromium.org/1494863002/diff/1/mojo/edk/embedder/simple_pl...
mojo/edk/embedder/simple_platform_shared_buffer_unittest.cc:137: if
(base::SysInfo::AmountOfVirtualMemory() &&
I added this recently to make the test pass on Windows XP, but didn't test it on
Linux after. Apparently this returns 0 on Linux.

https://codereview.chromium.org/1494863002/diff/1/mojo/edk/system/handle_tabl...
File mojo/edk/system/handle_table.cc (right):

https://codereview.chromium.org/1494863002/diff/1/mojo/edk/system/handle_tabl...
mojo/edk/system/handle_table.cc:84: CHECK(handles);
for here and below, there were death tests that expected the check to fire. for
release they were compiled out.

[yzshen1, 2015-12-03 18:04:33]

LGTM

https://codereview.chromium.org/1494863002/diff/1/mojo/edk/embedder/simple_pl...
File mojo/edk/embedder/simple_platform_shared_buffer_unittest.cc (right):

https://codereview.chromium.org/1494863002/diff/1/mojo/edk/embedder/simple_pl...
mojo/edk/embedder/simple_platform_shared_buffer_unittest.cc:137: if
(base::SysInfo::AmountOfVirtualMemory() &&
On 2015/12/03 03:42:36, jam wrote:
> I added this recently to make the test pass on Windows XP, but didn't test it
on
> Linux after. Apparently this returns 0 on Linux.

nit: please consider adding the reason as a comment in the code.

[jam, 2015-12-03 18:11:55]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-12-03 18:28:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1494863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1494863002/1

[commit-bot: I haz the power, 2015-12-03 18:39:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-03 18:41:02]

Description was changed from

==========
Fix the new Mojo EDK's mojo_system_unittests to pass in release builds and also
on Linux.

BUG=556259
==========

to

==========
Fix the new Mojo EDK's mojo_system_unittests to pass in release builds and also
on Linux.

BUG=556259

Committed: https://crrev.com/4bb42cddc22e6d4d25bf70525c5c094d0b67c691
Cr-Commit-Position: refs/heads/master@{#363018}
==========

[commit-bot: I haz the power, 2015-12-03 18:41:03]

Patchset 1 (id:??) landed as
https://crrev.com/4bb42cddc22e6d4d25bf70525c5c094d0b67c691
Cr-Commit-Position: refs/heads/master@{#363018}