Fix the new Mojo EDK's mojo_system_unittests to pass in release builds and also on Linux.

mojo/edk/system/handle_table.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/edk/system/handle_table.h"
 
 #include <limits>
 
 #include "base/logging.h"
 #include "mojo/edk/system/configuration.h"
@@ skipping 63 matching lines @@
   return std::make_pair(AddDispatcherNoSizeCheck(dispatcher0),
                         AddDispatcherNoSizeCheck(dispatcher1));
 }
 
 bool HandleTable::AddDispatcherVector(const DispatcherVector& dispatchers,
                                       MojoHandle* handles) {
   size_t max_message_num_handles = GetConfiguration().max_message_num_handles;
   size_t max_handle_table_size = GetConfiguration().max_handle_table_size;
 
   DCHECK_LE(dispatchers.size(), max_message_num_handles);
-  DCHECK(handles);
+  CHECK(handles);

[jam, 2015/12/03 03:42:36]

for here and below, there were death tests that expected the check to fire. for
release they were compiled out.

   DCHECK_LT(
       static_cast<uint64_t>(max_handle_table_size) + max_message_num_handles,
       std::numeric_limits<size_t>::max())
       << "Addition may overflow";
 
   if (handle_to_entry_map_.size() + dispatchers.size() > max_handle_table_size)
     return false;
 
   for (size_t i = 0; i < dispatchers.size(); i++) {
     if (dispatchers[i]) {
       handles[i] = AddDispatcherNoSizeCheck(dispatchers[i]);
     } else {
       LOG(WARNING) << "Invalid dispatcher at index " << i;
       handles[i] = MOJO_HANDLE_INVALID;
     }
   }
   return true;
 }
 
 MojoResult HandleTable::MarkBusyAndStartTransport(
     MojoHandle disallowed_handle,
     const MojoHandle* handles,
     uint32_t num_handles,
     std::vector<DispatcherTransport>* transports) {
   DCHECK_NE(disallowed_handle, MOJO_HANDLE_INVALID);
-  DCHECK(handles);
+  CHECK(handles);
   DCHECK_LE(num_handles, GetConfiguration().max_message_num_handles);
   DCHECK(transports);
   DCHECK_EQ(transports->size(), num_handles);
 
   std::vector<Entry*> entries(num_handles);
 
   // First verify all the handles and get their dispatchers.
   uint32_t i;
   MojoResult error_result = MOJO_RESULT_INTERNAL;
   for (i = 0; i < num_handles; i++) {
@@ skipping 113 matching lines @@
   for (uint32_t i = 0; i < num_handles; i++) {
     HandleToEntryMap::iterator it = handle_to_entry_map_.find(handles[i]);
     DCHECK(it != handle_to_entry_map_.end());
     DCHECK(it->second.busy);
     it->second.busy = false;
   }
 }
 
 }  // namespace edk
 }  // namespace mojo