Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1494633002: Fix TSAN error in skia/chromium ref count debug checks (Closed)

Created:
5 years ago by Justin Novosad
Modified:
4 years, 12 months ago
Reviewers:
Stephen White
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TSAN error in skia/chromium ref count debug checks Using std::atomic to make debug checks thread safe. BUG=509693 R=senorblanco@chromium.org Committed: https://crrev.com/0d030275667855c06be6cfc2ac10fb434d7ed771 Cr-Commit-Position: refs/heads/master@{#363274} Committed: https://crrev.com/3e471195b0826a8b8228fefd378930f65c2671b0 Cr-Commit-Position: refs/heads/master@{#366750}

Patch Set 1 #

Patch Set 2 : fix build deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M skia/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M skia/config/sk_ref_cnt_ext_debug.h View 1 1 chunk +11 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
Justin Novosad
PTAL
5 years ago (2015-12-04 15:44:20 UTC) #1
Stephen White
LGTM
5 years ago (2015-12-04 19:02:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494633002/1
5 years ago (2015-12-04 19:37:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 19:52:30 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0d030275667855c06be6cfc2ac10fb434d7ed771 Cr-Commit-Position: refs/heads/master@{#363274}
5 years ago (2015-12-04 19:53:14 UTC) #7
jam
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1500033003/ by jam@chromium.org. ...
5 years ago (2015-12-04 20:05:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494633002/20001
4 years, 12 months ago (2015-12-23 15:23:24 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 12 months ago (2015-12-23 16:21:40 UTC) #14
commit-bot: I haz the power
4 years, 12 months ago (2015-12-23 16:22:51 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e471195b0826a8b8228fefd378930f65c2671b0
Cr-Commit-Position: refs/heads/master@{#366750}

Powered by Google App Engine
This is Rietveld 408576698