Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1494483002: Revert of compositor-worker: Refactor CompositorWorkerManager (Closed)

Created:
5 years ago by tkent
Modified:
5 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of compositor-worker: Refactor CompositorWorkerManager (patchset #16 id:290001 of https://codereview.chromium.org/1449953002/ ) Reason for revert: It caused consistent timeout of webexposed/global-interface-listing-compositor-worker.html https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/15965 Original issue's description: > compositor-worker: Refactor CompositorWorkerManager > > Much of the functionality in CompositorWorkerManager > was related to shared compositor thread state. This > patch moves that to CompositorWorkerSharedState, an > implementation detail of CompositorWorkerThread. > > The shared state also now uses the real compositor > thread. > > The existing compositor worker layout tests needed > to be moved to a virtual test suite since they now > depend on having a compositor thread. > > BUG=430155 > > Committed: https://crrev.com/d710cbc079b51b819349203ee408f36dc056055e > Cr-Commit-Position: refs/heads/master@{#362590} TBR=piman@chromium.org,haraken@chromium.org,rbyers@chromium.org,sadrul@chromium.org,skyostil@chromium.org,vollick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=430155 Committed: https://crrev.com/99a58a8721111e066db995e3297b9ca554e78503 Cr-Commit-Position: refs/heads/master@{#362641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+763 lines, -783 lines) Patch
M components/scheduler/child/webthread_impl_for_worker_scheduler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/scheduler/child/webthread_impl_for_worker_scheduler.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M content/child/blink_platform_impl.h View 4 chunks +1 line, -20 lines 0 comments Download
M content/child/blink_platform_impl.cc View 5 chunks +6 lines, -23 lines 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +1 line, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 5 chunks +55 lines, -61 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +0 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/compositorworker/compositor-attribute-change.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/compositorworker/compositor-attribute-change-worker.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/compositorworker/compositor-proxy-disconnect.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/compositorworker/compositor-proxy-disconnect-worker.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/compositorworker/compositor-proxy-disconnect-worker-terminate.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/compositorworker/compositor-proxy-postmessage.html View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/compositorworker/resources/proxy-disconnect.js View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/compositorworker/resources/proxy-echo.js View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/compositorworker/resources/proxy-idle.js View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/compositorworker/resources/proxy-mutate.js View 1 chunk +14 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-attribute-change.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-attribute-change-worker.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-disconnect.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-disconnect-worker.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-disconnect-worker-terminate.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-postmessage.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-disconnect.js View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-echo.js View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-idle.js View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/resources/proxy-mutate.js View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/InitModules.cpp View 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorker.h View 2 chunks +1 line, -2 lines 0 comments Download
A third_party/WebKit/Source/modules/compositorworker/CompositorWorkerManager.h View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/compositorworker/CompositorWorkerManager.cpp View 1 chunk +152 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/compositorworker/CompositorWorkerManagerTest.cpp View 1 chunk +279 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp View 2 chunks +8 lines, -145 lines 0 comments Download
D third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +0 lines, -305 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tkent
Created Revert of compositor-worker: Refactor CompositorWorkerManager
5 years ago (2015-12-02 06:08:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494483002/1
5 years ago (2015-12-02 06:09:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 06:11:57 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-02 06:13:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99a58a8721111e066db995e3297b9ca554e78503
Cr-Commit-Position: refs/heads/master@{#362641}

Powered by Google App Engine
This is Rietveld 408576698