Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: content/child/blink_platform_impl.cc

Issue 1494483002: Revert of compositor-worker: Refactor CompositorWorkerManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/blink_platform_impl.h ('k') | content/renderer/render_thread_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/blink_platform_impl.cc
diff --git a/content/child/blink_platform_impl.cc b/content/child/blink_platform_impl.cc
index f866e717775868694ba3e2ddc85b758b484eb7e4..cb6a4fdebe2206c7629d6d52f355479f39f80590 100644
--- a/content/child/blink_platform_impl.cc
+++ b/content/child/blink_platform_impl.cc
@@ -25,7 +25,6 @@
#include "base/sys_info.h"
#include "base/thread_task_runner_handle.h"
#include "base/threading/platform_thread.h"
-#include "base/threading/thread.h"
#include "base/time/time.h"
#include "base/trace_event/memory_allocator_dump_guid.h"
#include "base/trace_event/memory_dump_manager.h"
@@ -443,8 +442,7 @@
BlinkPlatformImpl::BlinkPlatformImpl(
scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner)
- : main_thread_task_runner_(main_thread_task_runner),
- compositor_thread_(nullptr) {
+ : main_thread_task_runner_(main_thread_task_runner) {
InternalInit();
}
@@ -464,11 +462,9 @@
}
}
-void BlinkPlatformImpl::UpdateWebThreadTLS(blink::WebThread* thread,
- base::WaitableEvent* event) {
+void BlinkPlatformImpl::UpdateWebThreadTLS(blink::WebThread* thread) {
DCHECK(!current_thread_slot_.Get());
current_thread_slot_.Set(thread);
- event->Signal();
}
BlinkPlatformImpl::~BlinkPlatformImpl() {
@@ -533,20 +529,11 @@
}
blink::WebThread* BlinkPlatformImpl::createThread(const char* name) {
- return createThreadWithOptions(name, base::Thread::Options()).release();
-}
-
-scoped_ptr<scheduler::WebThreadBase> BlinkPlatformImpl::createThreadWithOptions(
- const char* name,
- base::Thread::Options options) {
- scoped_ptr<scheduler::WebThreadBase> thread(
- new scheduler::WebThreadImplForWorkerScheduler(name, options));
- base::WaitableEvent event(false, false);
+ scheduler::WebThreadImplForWorkerScheduler* thread =
+ new scheduler::WebThreadImplForWorkerScheduler(name);
thread->TaskRunner()->PostTask(
- FROM_HERE,
- base::Bind(&BlinkPlatformImpl::UpdateWebThreadTLS, base::Unretained(this),
- base::Unretained(thread.get()), base::Unretained(&event)));
- event.Wait();
+ FROM_HERE, base::Bind(&BlinkPlatformImpl::UpdateWebThreadTLS,
+ base::Unretained(this), thread));
return thread;
}
@@ -1096,10 +1083,6 @@
base::RandBytes(buffer, length);
}
-blink::WebThread* BlinkPlatformImpl::compositorThread() const {
- return compositor_thread_;
-}
-
blink::WebGestureCurve* BlinkPlatformImpl::createFlingAnimationCurve(
blink::WebGestureDevice device_source,
const blink::WebFloatPoint& velocity,
« no previous file with comments | « content/child/blink_platform_impl.h ('k') | content/renderer/render_thread_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698