Issue 1494323002: Revert "Precompilation/x64: Load float vector constants via Thread."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1494323002: Revert "Precompilation/x64: Load float vector constants via Thread." (Closed)

Created:
5 years ago by rmacnak

Modified:
5 years ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Precompilation/x64: Load float vector constants via Thread." This reverts commit 9cf30c9697afdf480b09133d80436f1a23228af7. Committed: https://github.com/dart-lang/sdk/commit/7dfb5176187a055150570ae4e78586bce6050e0e

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+117 lines, -131 lines)			Patch
M	runtime/vm/assembler_arm64_test.cc	View	10 chunks	+26 lines, -13 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	4 chunks	+64 lines, -16 lines	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	10 chunks	+12 lines, -20 lines	0 comments	Download
M	runtime/vm/thread.h	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	runtime/vm/thread.cc	View	1 chunk	+0 lines, -45 lines	0 comments	Download
M	runtime/vm/unit_test.h	View	2 chunks	+13 lines, -25 lines	0 comments	Download

Total messages: 4 (2 generated)

rmacnak

5 years ago (2015-12-03 22:19:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7dfb5176187a055150570ae4e78586bce6050e0e (presubmit successful).